| Project: | UC Worldpay |
| Version: | 6.x-1.0-rc1 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
I started using this module on a new site after using ecommerce and its worldpay module (thanks Dublin Drupaller) on some older sites which had some features I liked so I've created a patch to port them over.
This is a somewhat duplicate of:
http://drupal.org/node/369096
http://drupal.org/node/515546
This patch adds the following fields to worldpay settings form:
- Worldpay MD5 secret - so that you can secure your transactions and prevent tampering
- Worldpay number of minutes valid - so that you can limit the amount of time a user has to complete their transaction on the worldpay server
The patch passes a new variable to worldpay called MC_callback which is the worldpay completion url. If you set your callback to <wpdisplay item=MC_callback> in your worldpay account setting (on the worldpay site) it allows you to use one worldpay account for several sites.
The patch removes switch as this card type no longer exists.
The patch requires the download of the new logo (avaliable here http://www.rbsworldpay.com/images/cardlogos/poweredByRBSWorldPay.gif) and to put this in the images directory.
The patch also theme's the completion page using the site's theme.
All comments on the patch welcome! I have tested this on my own site and it's working.
| Attachment | Size |
|---|---|
| uc_worldpay.patch | 12.4 KB |
Comments
#1
alexpott, I've updated the logo - http://drupal.org/cvs?commit=281086
I'll take a proper look at your patch asap.
#2
matason, I've updated the patch to only do the necessary and to work against the HEAD version of uc_worldpay and I've changed this issue title to reflect that.
On my live site I've found it useful if the order status is updated to canceled if the user presses the cancel button on the worldpay screens so I've added the one line for that functionality.
Plus just to let you know, the latest nightly build is not available on the project page and in cvs the Drupal-6--1 branch doesn't seem to have the latest code...
#3
I've attached a patch based on @alexpott's code, it's against HEAD/RC1 and adds support for md5 - I've not been able to test this so would appreciate any feedback.
Let's look at the other items raised here and open separate issues for each if still required.
Once again, big thank you to @alexpott!