I've done a quick and dirty emwave implementation, to allow those with access to google wave's developer preview to embed a wave. It's mostly a find a replace of emimage, but it seems to work in my limited testing. There are more than a few things left to do, and also probably some cruft left over from emimage, but heh, 'release early, release often' right?

CommentFileSizeAuthor
#4 wave_embedded.jpg131.21 KBbcn
#3 emwave2.patch28.29 KBbcn
#3 emwave.zip7.02 KBbcn
#2 emwave.patch26.06 KBbcn
wave-embed3.JPG25.92 KBbcn
wave-embed2.JPG28.24 KBbcn
wave-embed1.JPG37.98 KBbcn
wave-embed-settings.JPG66.92 KBbcn
emwave.zip7.26 KBbcn

Comments

vadbars@drupal.org’s picture

vadbars@drupal.org commented

I wrote about my experiences here - http://groups.drupal.org/node/24621#comment-85175

bcn’s picture

bcn commented
Status: Needs review » Needs work
StatusFileSize
new emwave.patch26.06 KB

Here is a patch that has even more cruft removed. Still needs some work, but it's ready to test.

bcn’s picture

bcn commented
StatusFileSize
new emwave.zip7.02 KB
new emwave2.patch28.29 KB

Updated patch... Mostly a cleanup, but also added the ability to have multiple waves embedded, either with multiple fields, or multiple items on a single field.

Since not many people have access to wavesandbox.com yet, it might make sense to first develop this at http://drupal.org/project/wave instead of committing code underneath the emfield project. One question this brings up is whether or not a emfield contrib module has to live inside /emfield/contrib, or not?

bcn’s picture

bcn commented
StatusFileSize
new wave_embedded.jpg131.21 KB

screenshot

aaron’s picture

aaron commented

i would love to be able to review this, but google never responded to my request for a beta account some time back. anyone want to invite aaronwinborn@gm...? :P

bcn’s picture

bcn commented

@arron:

Would love to send you an invite, but (AFAIK) google hasn't given anyone invites to give out... I know that starting tomorrow, they are moving all of us over from the sandbox domain to wave.google.com, and we /might/ have the ability to 'nominate' others. We'll see what happens...

There are some details at http://www.readwriteweb.com/archives/everything_you_need_to_know_about_t...

aaron’s picture

aaron commented
Status: Needs work » Fixed

I have a google wave account, and went ahead and committed this module, since it's self-contained, just to get some more development eyes and interest on the project.

However, it currently only works for the Google Wave Sandbox, at https://www.google.com/a/wavesandbox.com/ServiceLogin and not the actual Google Wave at https://wave.google.com/wave/ -- I can easily modify the provider file accordingly, but don't see how to embed waves in the first place from its interface -- perhaps that's something that can only be accomplished from the sandbox?

aaron’s picture

aaron commented
Status: Fixed » Needs work

marking as needs work until we resolve the question re. embedding normal waves.

bcn’s picture

bcn commented

Thanks Aaron for committing this.

1) As you mentioned, this is not working yet for wave.google.com embeds...
I see a few options here, i) change to allow for embeds from either sandbox or production servers (either by writing another provider .inc file, or a radio select in the field setting), or ii) change to allow embeds only from production (ie wave.google.com) servers.

2) Is it possible to have settings on a per embedded wave (and presumably per-node) basis?
It could be nice to be able change the wave look (color/size) on a per wave basis, or (dis)allow other wave embed api features on a per wave basis. Has this came up before, or how do other emfield modules deal with this?

3) How to build off, or coordinate with drupal.org/project/wave, and consider what other integrations/implementations (e.g. wave 'as a node-type' vs wave 'as a field') might make sense.

juliendorra’s picture

juliendorra commented

@noahb and Aaron :

Wave is going to be used with many servers (that's why there is server name in the Wave ID : googlewave.com!w+7peNoPc-I for example) in the next months or so .

So a solution that can use the server name in the ID is probably more suitable.

It's probably not much of an issue right now... but we should keep that in mind anyway.

summit’s picture

summit commented

Subscribing, greetings, Martijn

ck9’s picture

ck9 commented

Hi can you very briefly describe what this does please? I'd like to create an intranet type site where project nodes have attached google waves, to which users can request being added.

dan.crouthamel’s picture

dan.crouthamel commented

Subscribing -- so does this work with the production servers yet?

gausarts’s picture

gausarts commented

Subscribing. Thanks