Posted by sivaji on July 25, 2009 at 6:07pm
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | user system |
| Category: | task |
| Priority: | normal |
| Assigned: | sivaji |
| Status: | closed (won't fix) |
| Issue tags: | Needs usability review, Novice |
Issue Summary
I thought it would be better to show current user's name instead of "my account" in secondary menu. I found function user_page_title in user.module already has statements to do this, but it does it's job in wrong manner (condition need to be reversed), i guess the actual statements suppose to be as below
function user_page_title($account) {
if ($account->uid == $GLOBALS['user']->uid) {
- return t('My account');
+ return t("@user's account", array('@user' => drupal_ucfirst($account->name)));
}
- return $account->name;
+ return t('My account');
}
Comments
#1
Attached is a patch which tries to fix this.
#2
The last submitted patch failed testing.
#3
I think that the patch is failing testing because of this OpenID test on line 153 of openid.test:
$this->assertText(t('My account'), t('User was logged in.'));Due to this change, "My account" no longer exists as text. I tried to fix it but got stuck. Looking forward to seeing the solution.
#4
This patch breaks breadcrumb in
user/%/editpage.#5
Attached is a patch which tries to set proper title for secondary menu, user page and breadcrumb. Looking forward for input to fix the error mentioned in #3.
#6
The last submitted patch failed testing.
#7
changing issue properties.
#8
I think from a usability standpoint "My account" is better.
#9
I also think that Admin's account, actually makes it feel less personal and more abstract. I am tempted to mark this as a won't fix.
#10
I'm absolutely in favour of keeping this the way it is too.
#11
Won't fix it is then.
#12
Looks like it is fixed now. I see username in the secondary menu instead of "My account" :P.