Hello!
Everytime when I click "next" - I create new revision.
I think it's badly for those who used views of revisions. Any chance to turn off this feature?

Comments

vkareh’s picture

I hadn't thought of that until now, but I see several possibilities:

  1. Prevent revisions until after all of the steps have been submitted at least once, then create a revision for each new submission of the form.
  2. Prevent revisions until after all of the steps have been submitted at least once, then create one revision when editing multiple steps in one go (I'm guessing something like mark for editing and create a revision as soon as the editing action is complete, hence having only one new revision after batch-editing multiple steps).
  3. Provide new revisions whenever a step that was submitted previously is submitted again.

On the same note, I've been thinking about the Published status. Should the record be kept in an Unpublished state until after all of the steps have been submitted? Or should it be marked Published as soon as it's created? Maybe I'll provide both options and let each website admin decide.

Anonymous’s picture

Title: Revisions » Revisions and Published state
Version: 6.x-1.3 » 6.x-1.x-dev

I don't think it's a good idea to have a node be published after only the first step, especially if required fields are located on later steps...

I'd like to vote for keeping nodes un-published until the last step, possibly even until the 'Finish' button is clicked (as opposed to the 'Save progress' button)...

vkareh’s picture

For certain content types I can see the necessity of not publishing them until they are complete, although I have a website that could benefit from having nodes published with incomplete data. In this case we're talking about hundreds of fields and dozens of steps, but I see a need regardless.

I'm thinking of just a simple setting where the user (i.e. content type administrator) decides whether they want their nodes to follow the basic workflow settings, or to wait until all the steps are submitted.

As for the revisions, that could be more complex... I see several options here:

  • revision created at each submit - this is the default right now
  • at each submit of a step that was previously submitted
  • at each submit after the all the steps are marked as submitted
  • at each submit of a previously submitted step when all steps are marked as submitted
  • at the submit of all steps again after all steps were marked as submitted

phew! you get the idea... I'll start with the published state setting and wait on some more feedback for the revisions part.

Anonymous’s picture

Re. revisions, what about:

  • Each time the 'Finish' button is pressed

That way you don't have to worry about making sure all steps have been completed (cause the Finish button only appears on the last step), and users that want to skip a step can do so and still get a new revision...

vkareh’s picture

Status: Active » Needs review
StatusFileSize
new10.99 KB

Here's a patch with several options. Once applied, you have to go to the admin section (admin/settings/multistep) to configure the revisions and publishing behavior.

This patch includes the changes from #560748: Separate 'Hide standard buttons' settings, since I haven't committed those changes yet. Use the latest development snapshot.

vkareh’s picture

StatusFileSize
new11.07 KB

Fixed a situation in which the revisions were created during the process of completing the node, as opposed to creating revisions of a completed node.

vkareh’s picture

StatusFileSize
new9.75 KB

This is the same patch, without the code for #560748: Separate 'Hide standard buttons' settings, for sanity's sake.

vkareh’s picture

Status: Needs review » Fixed

Patch committed to development snapshot.

scottrigby’s picture

Interestingly, I'm not able to achieve the Publish "At node completion" option. The node publishes at every 'Next >' step :s

scottrigby’s picture

Specifically, the node publishes after completing the first step (the 'Published' flag is selected by default), but then it's unflagged for subsequent steps and finally published at the end. So all seems ok, except for publishing between the first and second steps :p

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Category: feature » bug
Status: Closed (fixed) » Active

I have a node (already created) that I'd like to un-publish, but I can't.
Whenever I untick 'Published' and hit 'Save' or 'Next', it still shows 'Published' as ticked.
I can't un-publish my nodes!

My multistep is set to pubish 'At node completion'. Even trying to un-publish on the last step doesn't work...

Anonymous’s picture

Priority: Normal » Critical

Marking as critical...

Bilmar’s picture

subscribing

vkareh’s picture

Status: Active » Fixed

I changed the code to verify whether the Published checkbox is checked. Now you can uncheck it to Unpublish your nodes. Keep in mind that it might be marked again after you Save, although the node will still be Unpublished, so that the node can be Published again after it's completed.

The fix is now in the latest development snapshot.

Daniel A. Beilinson’s picture

Thanx.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.