Download & Extend
Activism » Issues

activism letter module

Posted by stella on July 25, 2009 at 11:04pm
Project:Activism
Version:6.x-2.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs review

Issue Summary

Here's a first stab at the activism letter module for letter writing campaigns. It allows the admin user to configure multiple recipients for a campaign. Each recipient can have a customised email subject and message. The end user participating in the campaign can then choose which of the configured recipients to email and the associated subject /message for that recipient appears accordingly. This was based on letter campaign at http://www.trocaire.org/en/takeaction/gazaaction.

I haven't run it through coder or written up simpletests for it yet, so keep that in mind. If you like the direction I took with it, then I'll come back to those bits then. Just wanted to post something and get feedback.

Cheers,
Stella

AttachmentSize
activism_letter.tgz5.79 KB
Login or register to post comments

Comments

#1

Posted by Morbus Iff on July 26, 2009 at 1:44am

Ooh, fun. We had dummied up a quickie letter writing module of our own internally, that just hadn't had time to go through the Morbus wringer for release. It'll be neato to compare the two when I've the time. Keep going, certainly.

#2

Posted by stella on July 27, 2009 at 9:44am

Ok I'm away for most of this week, but will take another look at it after that.

Couple of points about the existing version:

  • It defines one message body per recipient. I'm not entirely sure I like this, but I did it this way because otherwise users would (a) need to define different, custom, token placeholders, which could vary with each campaign and (b) easiest way of supporting letters in different languages for the same campaign. The user shouldn't have to translate the node in order to see recipients with another language.
  • It doesn't currently use token placeholders - it probably should, to support standard tokens, such as recipient name, etc.
  • I based it on the activism tellafriend module, but didn't do a tidy-up for it, so there's may be some legacy code in there that could be removed.

#3

Posted by brianbrown on July 27, 2009 at 10:13pm

I don't think that this module is being maintained!
-Brian

#4

Posted by SethM on July 28, 2009 at 12:27am

I get the following error when I try to create a letter campaign:

warning: Invalid argument supplied for foreach() in /sites/default/modules/activism/activism_letter/activism_letter.module on line 238.

#5

Posted by stella on August 3, 2009 at 4:44pm

Here's an updated module which fixes the above error and implements a workaround for an IE issue with the 'change' js event. It also includes working simpletests - though these could be extended if you wished.

Cheers,
Stella

AttachmentSize
activism_letter.tgz 7.44 KB

#6

Posted by stella on January 19, 2010 at 7:17pm

ping! Any chance of this getting a review? or better yet a commit? :) I'm using this on a live site and it's working pretty well for about 6 months now.

#7

Posted by rjmackay on January 19, 2010 at 7:56pm

This looks pretty good to me. I've been using it as a basis for a fax sending module.
The only problem I've seen is that emails are sent from: the site admin, not the user sending them.