Closed (fixed)
Project:
Patterns
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Jul 2009 at 12:12 UTC
Updated:
28 Jul 2009 at 09:10 UTC
Here's an example minimal pattern
All I want is
variable_set("site_map_show_rss_links", FALSE);
<?xml version="1.0" encoding="ISO-8859-1"?>
<pattern>
<info><!-- blah blah --></info>
<actions>
<variable name="site_map_show_rss_links">0</variable>
</actions>
</pattern>
... does not work due to a line in the middle of system.inc
A common oversight - needed isset().
- if (!$item['value'] && !$item['delete']) {
+ if (! isset($item['value']) && !$item['delete']) {
$value = $item;
It actually ends up putting a malformed array into the variable ... which registers as TRUE , so we can never turn things off.
Patch attached.
| Comment | File | Size | Author |
|---|---|---|---|
| patterns-allow_variables_to_be_set_to_false.patch | 795 bytes | dman |
Comments
Comment #1
sarvab commentedNice catch. Fix committed and should be no reason for review here so closing.