I converted your really good module to D7 about 2 months ago, and I was using it to develop my modules in D7 with this module dependency. I thought that it is too early to submit but somebody said to me that I should..

CommentFileSizeAuthor
#9 531840-d7.patch5.68 KBboombatower
#8 profile_role_D7.patch5.27 KBtutumlum
#7 profile_role_D7.patch5.24 KBtutumlum
#5 profile_role.patch5.2 KBtutumlum
#4 531840-d7.patch5.87 KBboombatower
#3 531840-d7.patch4.83 KBboombatower
#2 531840-d7.patch4.91 KBboombatower
profile_role_D7.zip2.28 KBtutumlum

Comments

boombatower’s picture

boombatower commented
Version: 6.x-1.x-dev » 7.x-1.x-dev

Branched HEAD for 6.x and created 7.x nightly.

boombatower’s picture

boombatower commented
Status: Active » Needs review
StatusFileSize
new 531840-d7.patch4.91 KB

Looks like you were using one version older of the code and there is some debug code in there. Here is a patch to get us started.

boombatower’s picture

boombatower commented
StatusFileSize
new 531840-d7.patch4.83 KB

Further tweaked.

boombatower’s picture

boombatower commented
StatusFileSize
new 531840-d7.patch5.87 KB

Test doesn't seem to pass.

PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'drupal-7.simpletest208379profile_field' doesn't exist: SELECT DISTINCT(category) FROM {profile_field};
tutumlum’s picture

tutumlum commented
StatusFileSize
new profile_role.patch5.2 KB

I made another patch. This is first time I made patch. I tested it works. I tried the last patch you send, it didn't work, maybe I'm missing something. I checked change log to see difference between version 1.3 and 1.4 but I couldn't see it.

tutumlum’s picture

tutumlum commented

I just noticed a bug, and fixed it..

tutumlum’s picture

tutumlum commented
StatusFileSize
new profile_role_D7.patch5.24 KB

ops.. no file :)

tutumlum’s picture

tutumlum commented
StatusFileSize
new profile_role_D7.patch5.27 KB

I noticed one more bug, fixed it. By the way, this and previous patches are for the HEAD from CVS.

boombatower’s picture

boombatower commented
StatusFileSize
new 531840-d7.patch5.68 KB

Went ahead and merged my changes back into your patch.

.info file
* (all) files should end with blank line for patching
* version should not be specified.

profile_role.module
* Patch used
// $Id: profile_role.module,v 1.4 2009/01/23 20:11:43 boombatower Exp $

latest head
// $Id: profile_role.module,v 1.5 2009/02/15 03:09:11 boombatower Exp $

Not sure what is going on there, but I suppose we are ok.

* Seem to keep leaving debug code in the patch, such as //print_r($form_state); , //return print_r($result); , print_r($roles);

* Standard says that foreach ($foo as $bar) the 'as' should be lower.

Added CHANGELOG.txt entry.

boombatower’s picture

boombatower commented
Status: Needs review » Fixed

Committed.

Thanks for providing the update!

tutumlum’s picture

tutumlum commented

:) I have problems about standards. I am trying to get cvs account my high volume modules to upload ( http://drupal.org/node/531440 ), but KiamLaLuno is not letting me to go in :) Just kidding, he is right, he is correcting me much, I am getting used to well... By the way, I just changed all "AS" to lower for all of my modules, as you suggest :).

Thank you, I am falling in love with Drupal community :P :))

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.