I installed the module, but I got an error about a not existing database table; I tried to add a new comment to an issue, but I still got an error about a not existing table.
When I then uninstalled it, I got this error message:

user warning: Unknown table 'comment_acl_history' query: DROP TABLE comment_acl_history in /Applications/MAMP/htdocs/dr6/includes/database.mysql-common.inc on line 261.
CommentFileSizeAuthor
#2 532792-comment-acl-install-error-2.patch622 bytescoltrane

Comments

avpaderno’s picture

The only error I can find is in the schema definition, which declares the primary key using a nid field that in not defined.

function comment_acl_schema() {
  $schema['comment_acl_history'] = array(
    'fields' => array(
      'acl_id' => array(
        'type' => 'int',
        'unsigned' => TRUE,
        'not null' => TRUE,
        'description' => 'The {node}.nid of the node.',
      ),
      'cid' => array(
        'type' => 'int',
        'unsigned' => TRUE,
        'not null' => TRUE,
        'description' => 'The {comment}.cid of the comment.',
      ),
      'uid' => array(
        'type' => 'int',
        'unsigned' => TRUE,
        'not null' => TRUE,
        'description' => 'The {user}.uid of the user to grant access to.',
      ),
    ),
    'primary key' => array('nid', 'cid', 'uid'),
  );
  return $schema;
}

As the acl_id definition contains "The {node}.nid of the node." as description, I would guess the nid field is really acl_id (or vice versa).

coltrane’s picture

Status: Active » Needs review
StatusFileSize
new622 bytes

Patch makes key change

greggles’s picture

Status: Needs review » Reviewed & tested by the community

Tested and confirmed.

damien tournoud’s picture

Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.