Rules usability issues

>Rule sets are similar in concept to subroutines and can be executed as actions or manually by code or another module.

As you noted above, rule sets are invoked and evaluated. Thus the action executes and invokes the rule set. So I think the old wording is fine in that case.

@RULES_ADMIN_TRIGGER_PATH help:
hm, I must say again I prefer the old message. The rules are not all rules, they are just the triggered ones (compared to them in the sets that aren't listed here). Then the rule doesn't consist of the event, the event is assigned to the rule or the other way round. So I'd again just leave the old message. If they aren't really bad or wrong worded it's better to leave them anyway, as existing translations stay intact!

@rules_admin/rules_admin.sets.inc
all fine here :)

@rules_admin/rules_admin.export.inc

Not all rule sets start with 'rules_' - just the one created by the rules UI. So we have to test for 'event_' as else. Best I'd suggest to refactor that and finally add a small function that checks that for a given rule *or* event/setname to the rules.admin.inc file. Thus you can improve your code in export.inc and just use array_filter on the 'rule' items.

@event headline:
Hm, that way the headline is somehow lost. What about doing the change I already mentioned:

Use
ON
IF (instead "conditions")
....
DO (instead of "actions")
...

That way I think it makes sense. The only I thing I wonder then is what if there are no conditions. Then there is only "IF" and the add condition link. Perhaps we just shouldn't show the IF in that case?

> // filter out rules within rule sets, we only want event-triggered rules

I don't understand this part. Can you please give an exmaple of a non-event triggered rule? (Also comment should start with capital letter and end with a dot).

+function rules_admin_is_event_rule($rule) {
+  if (isset($rule['#set'])) {
+    return strpos($rule['#set'], 'event_') === 0;
+  }
+  return FALSE;

I think this can be shorter:

function rules_admin_is_event_rule($rule) {
  return !empty($rule['#set']) && strpos($rule['#set'], 'event_') === 0;
}

+    $render['event_headline'] = array('#weight' => -10, '#value' => '<h3 class="event">'. t('ON event %event', array('%event' => $event_label)) .'</h3>');

I think it's nicer if the <h3 class="event"> part would be in #prefix and #suffix.

>+ if (isset($element['#conditions'][0])) {

While 0 is usually the key for UI created rules this has not to be so - they key might be anything. So best check whether element_children($element['#conditions']) is empty.

String change: Agreed that the change is good, but let's help our translators and search/replace this string also in the .po files. Thus the translation stays, which I think is better than loosing it.

@prefix, suffix: Hm, I'm fine with both ways. I agree that adding it via formapi keys is nice, but in the case of single html elements not really necessary and just makes the code longer.

thanks, committed. :)