mobileplugin overrides the admin theme variable

It seems mobileplugin overrides the admin theme variable. From looking at the code in Mobile Tools module, the theme can be changed by setting the global $conf['theme_default'] in hook_init() too.

Also, many other variables can also be changed in hook_init(), for example, 'site_name', 'site_slogan', 'default_nodes_main', 'page_title_front', 'page_title_default'.

I globaled $user on hook_init and updated the following code:

if (!user_access(MOBILEPLUGIN_ENABLE) || $user->uid == 1) {
return;
}

Works for admin.

subscribe

The change suggested above appears to cause all images to get scaled no matter what when logged in as uid 1. Perhaps a better change would be to check for uid 1 in function _mobileplugin_set_theme(). Here's what I did and it fixed both problems for me:

function _mobileplugin_set_theme() {
global $mobileplugin_group, $custom_theme, $user;
if (($group != MOBILEPLUGIN_FULL_GROUP) && ($user->uid != 1)) {
$grouplist = _mobileplugin_get_groups();
$custom_theme = $grouplist[$mobileplugin_group]['theme'];
}
}

anyone up for making a patch or putting in dev to try out?

I hacked the module code too and it worked for me :-)

The change in #4 means that the superuser will never use the mobile theme.

The real problem is that the variable that is globaled is called mobileplugin_group but the if test is using $group

The function should be

function _mobileplugin_set_theme() {
global $mobileplugin_group, $custom_theme, $user;

if ($mobileplugin_group != MOBILEPLUGIN_FULL_GROUP ) {
$grouplist = _mobileplugin_get_groups();
$custom_theme = $grouplist[$mobileplugin_group]['theme'];
}
}

subscribe

subscribing (2.x)

The error is located in line 220 on the file mobileplugin.module, it is using a completely wrong variable name, now it looks like this:

if ($group != MOBILEPLUGIN_FULL_GROUP) {

But it really should be:
if ($mobileplugin_group != MOBILEPLUGIN_FULL_GROUP) {

The $group variable doesn't even exists, it is a typo, but could cause a lot of troubles especially if you rely somehow on the administration template. By using this change, it doesn't replace the template, unless it is a detected device belonging to a specific group.

That solves completely the problem.

Is this any different than what I posted in #6?

+1 on the $mobileplugin_group group fix in #9. That is an obvious bug and fixes the issue. This is still happening in 2.0

Fix in #9 works. Clear browser session data afterwards to see the changes take effect.

Has this been fixed in the latest version or is a hack still necessary?