When the file upload part of node form is checked to be vertical tab its make strange things. I add an file (jpg or PDF) and save the node normaly. But then I find out it is not accesible by anonymous -> because it was unpublished (but it was at the time I saved it). I choose to edit this node, but there were no wysiwyg (TinyMCE with IMCE) present, and no Vertical Tabs at all, but no other form fields (author, publish/unpublish, menu, revisions, ...) as well. Only Title, Body and the Upload field was present. And the node looks like it was published by anonymous...
When I unchecked the Upload file form from vertical Tabs, everything was OK again.

Comments

aangel’s picture

Hmm...I'm trying to see some of the behavior you mentioned. I want the non-checked fieldsets not to appear at all so I added the following clause at line 63 of vertical_tabs.module:

      } else {
          // AVA
          // If the element is a fieldset but it hasn't passed the above test 
          // (to add it to the vertical tabs) then remove it from the form.
          global $user;
          if (isset($form[$key]['#type']) && $form[$key]['#type'] == 'fieldset' && ($user->uid <> 1))     {
                unset($form[$key]);
          }
      }

and uploads are working fine.

neochief’s picture

Same thing for me, but I have cleaner explanation. When you have uploaded one file, on node editing form some scripts (possibly vertical tabs) are flushing all the fieldsets that are situated under the vertical tabs div, but vertical tabs table are not appering by itself. I cannot figure why, same installtion on two servers behave differently. Problem is not browser-dependent.

kiphaas7’s picture

Same here, as soon as a file is uploaded, all javascript get's broken. Vertical tabs, wysiwyg, etc...

bealdav’s picture

Version: 6.x-1.0-beta3 » 6.x-1.0-beta4
Priority: Normal » Critical
StatusFileSize
new21.83 KB

Still not working.

  • when you use upload file (any format)
  • previous author becomes anonymous
  • previous state becomes unpublished
  • fck editor doesn't works

Please may repair this ?

Thanks

dave reid’s picture

Priority: Critical » Normal
Status: Active » Postponed (maintainer needs more info)

Please test and re-confirm using the latest code, 6.x-1.0-beta6.

dave reid’s picture

Version: 6.x-1.0-beta4 » 6.x-1.0-beta7

Please give me step by step instructions to duplicate this. Which upload module (core upload or filefield)?

dave reid’s picture

Title: problem with file upload » Incompatability with file uploads
bwynants’s picture

same problem here with core upload

bealdav’s picture

StatusFileSize
new53.18 KB
new51.63 KB

the same problem again with core attachments

Drupal 6.14 et VT beta 7

dave reid’s picture

Status: Postponed (maintainer needs more info) » Closed (duplicate)

This is a duplicate of #656580: Fields with #prefix and #suffix fail miserably with vertical tabs because upload.module uses #prefix and #suffix. This needs to be fixed first in D7 then backported.

amourow’s picture

subscribe

efeefe’s picture

Version: 6.x-1.0-beta7 » 6.x-1.0-rc1

Similar problems with rc1. Subscribing.

kndr’s picture

Status: Closed (duplicate) » Needs review
StatusFileSize
new563 bytes

I can confirm this bug. Mistake in code is very small but effect is horrible. Source of problem lies inside javascript error (wrong parametr for function Drupal.formatPlural), not in #prefix and #suffix. I've reopened this issue since it is not duplicated. I am attaching the patch.

doomed’s picture

Hello,

I have exactly the same problem. Glad to find this has been reported, was starting to think I was crazy!

Using Drupal 6.20 / Vertical Tabs 6.x-1.x-dev .

Has this been fixed recently ?

kndr’s picture

I don't see any commits. Try apply #13. It fix my problems with attachements inside vertical tabs.

dave reid’s picture

Status: Needs review » Closed (duplicate)
doomed’s picture

Dave Reid,

What does that mean? That it can only be fixed via future Drupal 6 updates?

kndr’s picture

@doomed, it means that: D8 core should be fixed, first. D7 core should be fixed, next. Finally, D6 core should be fixed. Ta-da :) If you have no time, apply temporary patches.

doomed’s picture

Thanks kndr,

But if you have successfully patched the vertical tabs module, then the owner can patch it as well, right?

Thus, we wouldnt be waiting for a Drupal core update (which may or may not include this bug fix)?

kndr’s picture

@doomed Right. Maintainer can fix vertical_tabs but his decision is different. He (Dave Reid) signed this issue (at #16) as duplicated and we should wait for core updates first.

mykola kovbasa’s picture

Patch in #13 works fine to me, thanks