Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The Schema API was introduced in Drupal 6, we should use it to create and drop tables rather than db_query(). See #146862: Schema API quick start guide.
I will try and provide a patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | Paycom-534066.patch | 9.36 KB | kscheirer |
| #2 | Paycom-534066.patch | 9.27 KB | kscheirer |
Comments
Comment #1
kscheirernode link? #146862: Schema API quick start guide - http://drupal.org/node/146862
Comment #2
kscheirerAlso, the database names should be prefixed with your module name, like paycom, paycom_EpochTransStats, and paycom_MemberCancelStats.
It doesn't look like you're using EpochTransStats at all, so I'm just removing that table.
The
// $Id$string will automatically be replaced by Drupal packing script when you make a release - you don't need additional credit info usually.Comment #3
kscheireradded a @file declaration and removed some excess whitespace.
Comment #4
hypertext200Looking forward to commit to CVS
Comment #5
kscheirerlooks like I've misunderstood how your module works somewhat, sorry for the confusion.
I just recently got access to the docs that describe Epoch's operation, including the fact that MemberCancelStats and EpochTransStats are tables that get populated automatically by Epoch, not by this module. Because of that, the table names cannot change. It also means the schema api cannot be used, I'm fairly sure it requires tables to share a namespace with the module (ie all table names would have to start with paycom).
Comment #6
kscheireryou do know I can't commit to your CVS repository, right? You are the only maintainer for this project - I can only post patches.
Comment #7
hypertext200Now I grant access to you, you can commit these patches now :)