Download & Extend

Add first and last classes to table header cells

Project:Drupal core
Version:7.x-dev
Component:theme system
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (won't fix)

Issue Summary

In the initial d7ux theme issue, I've implemented table borders as it was possible with the current markup and classes, which caused them not to match the d7ux mockups. The mockups call for border on the left and right end of the table header to not exist. Since Drupal does not provide any markup to identify first and last table header cells in the table header, there was no way to hang styles on these elements. To fix this issue, we need to add first and last classes to table headers just like we do with lists. While the slate theme can just copy the theme_table() monster function, this simple modification is possibly useful to other themers too, so I'm proposing it for the core theme_table instead.

AttachmentSizeStatusTest resultOperations
table-first-last.patch1.42 KBIdleFailed: 11855 passes, 3 fails, 0 exceptionsView details | Re-test

Comments

#1

Status:needs review» needs work

The last submitted patch failed testing.

#2

Status:needs work» closed (won't fix)

I don't think we'll need this any longer since it was IE6 that didn't understand the first and last pseudo selectors. IE 7 supports it as does the rest of todays browsers.