Make sure all markup is forum specific [#534816]

The advanced_forum-topic-header.tpl.php and advf-forum-preview-post.tpl.php files contain an anchor link as follows:

<a id="top"></a>

Because the zen-based theme I'm using also uses an anchor tag named "top" this was causing a conflict and display error in Safari (tested versions 3 and 4).

Removing the anchor tag fixed my problem. As "top" is a common name for an anchor tag, I'd like to suggest that something more specific like

<a id="advf-top"></a>

might reduce the chance of similar conflicts in the future.

Comments

Comment #1

michelle

she/her

English

Wisconsin, USA

commented 29 July 2009 at 19:08

Title:	anchor tag conflict in Safari	» Change "top" anchor tag to something more specific
Version:	6.x-1.0	» 6.x-2.x-dev
Category:	bug	» feature

The fact that a theme uses the same anchor as I do isn't a bug. I'll consider changing it in 2.x but want to run it by some themers and get their opinion first.

Michelle

Comment #2

michelle

she/her

English

Wisconsin, USA

commented 30 July 2009 at 03:01

Status:

Active

» Fixed

Ok, discussed with stephthegeek and she agreed that "top" was too generic of an ID for a module to use so I changed it to "forum-topic-top".

Michelle

Comment #3

michelle

she/her

English

Wisconsin, USA

commented 30 July 2009 at 16:08

Title:	Change "top" anchor tag to something more specific	» Make sure all markup is forum specific
Status:	Fixed	» Active

Hijacking this issue a bit... It got me thinking that there may be other bits of markup that aren't specific enough in there. Going to give the styles a run through and make sure there's nothing else generic in them.

Michelle