Attached patch (against HEAD) adds two options to Fbconnect:
1. configuration setting that allows to skip the screen where user can create a local account or link to a local account and proceeds straight to registration
2. redirects user to the page he was on after successful login/registration eg. if user was posting a comment he is redirected to the same comment form not the home page

Comments

fumbling’s picture

Thanks for creating this patch. I tried it this afternoon. The patching process itself didn't display any errors in my SSH (putty), but got a warning on all pages of my installation that read:

warning: include_once(./sites/all/modules/fbconnect/fbconnect.module) [function.include-once]: failed to open stream: Permission denied in .../includes/bootstrap.inc on line 611.
warning: include_once() [function.include]: Failed opening './sites/all/modules/fbconnect/fbconnect.module' for inclusion (include_path='.:/usr/share/pear:/usr/share/php') in /var/www/html/sandbox/includes/bootstrap.inc on line 611.

And then when I tried to visit the fbconnect module's admin settings page I got:

Fatal error: require_once() [function.require]: Failed opening required 'sites/all/modules/fbconnect/fbconnect.admin.inc' (include_path='.:/usr/share/pear:/usr/share/php') in .../includes/menu.inc on line 346

Any thoughts? Thanks again for this patch, hope it makes it into the next release.

nonsie’s picture

Your file permissions on sites/all/modules/fbconnect/fbconnect.admin.inc seems to have gotten changed.

fumbling’s picture

Thanks. Just checked. So file permissions are currently set to 644, which seems to be normal, but I'm not certain. Should it be something else?

nonsie’s picture

Check the owner of the file in addition to read/write perms. Compare the permissions/owner of this file to other files in the same folder - they should all be the same.

fumbling’s picture

Thanks for bearing with me. I'm actually not sure how to check the owner of the file - researching now. Can that be done easily through the command line? Right-clicking on the file through ftp doesn't seem to have that as an option, at least in Filezilla. I was able to confirm that it does have the same permissions as the other files in the folder though.

UPDATE: so found the Owner/Group for all of the files in the fbconnect folder. They're all the same owner (root fumbling)

Any further thoughts?

klucid’s picture

Check the owner of the other modules. In my case, the owner was the login name. Applying that to all enclosed items worked for me.

hmmdinger’s picture

If I am working with the most recent release code from github, can I assume that this patch won't do me much good?

Also, how does this patch work? Does it automatically choose the first option, then automatically process with the user's name for username and email address as entered through the fbconnect lightbox?

vectoroc’s picture

Version: 6.x-1.0-beta8 »

I will apply this path soon

xurizaemon’s picture

I *think* this should be a fairly clean re-roll of this patch against current CVS. Untested.

The original patch includes many lines of output which aren't actual changes. Hope this helps.

vectoroc’s picture

path in repo

hmmdinger’s picture

Thanks! I tried yesterday to patch my local file manually, and it did not go well. :-)

I can verify that when the "Disable linking accounts..." option is checked, first-time visitors skip that linking page, and proceed to the registration form.

However, what I was hoping to see happen with that option is to skip the form as well. The form can be skipped because the user has just entered their email address and from that we know their Facebook name, right?

Can't a Drupal account be automatically created from their Facebook login information?

vectoroc’s picture

Status: Active » Fixed

hmmdinger: use fast registration mode

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

JStarcher’s picture

I have upgraded to Dev version and enabled fast registration and opted to skip the create account page but when I try to login with FB Connect I get:

* You must enter an e-mail address.
* Facebook connect registration failed for the reasons listed. You may register now, or if you already have an account you can log in now and link your account

Am I missing something? Perhaps the API changed?

Also I assume unable is actually enable here - "Unable this mode will bypass drupal's standard registration form."

dawansv’s picture

JStarcher:

Avoid posting to a closed issue because it might not get the attention you want...

Your problem looks like a duplicate of #778992: proxied_email no longer available?. See that issue for a solution.

Dmullenix’s picture

Version: » 6.x-2.0-beta1

Did you ever find a solution to this problem? I am having the same exact issue:

* You must enter an e-mail address.
* Facebook connect registration failed for the reasons listed. You may register now, or if you already have an account you can log in now and link your account