Download & Extend
FeedAPI » Issues

_feedapi_node_save performance: Skip node object creation when there are duplicates

Posted by ufku on July 30, 2009 at 2:43pm
Project:FeedAPI
Version:6.x-1.x-dev
Component:Code feedapi_node
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:Performance

Issue Summary

This patch changes _feedapi_node_save (by moving the x_dupe code higher) so that it checks the existence of duplicates before creating a new node object. And also FALSE is returned to indicate that the item is updated when there are duplicates.

Login or register to post comments

Comments

#1

Posted by ufku on July 30, 2009 at 2:50pm

patch

AttachmentSize
feedapi_node.x_dupe.patch 1.92 KB

#2

Posted by Aron Novak on August 18, 2009 at 8:24am
Status:needs review» reviewed & tested by the community

It does make sense.
I tested it with simpletest tests of FeedAPI and FeedAPI Mapper and it won't hurt :)
Also I tested it manually and it does not break the cross-feed deduping feature.

#3

Posted by Aron Novak on October 31, 2009 at 4:04pm
Status:reviewed & tested by the community» fixed

Committed. Thank you!

#4

Posted by System Message on November 14, 2009 at 4:10pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.