_feedapi_node_save performance: Skip node object creation when there are duplicates
ufku - July 30, 2009 - 14:43
| Project: | FeedAPI |
| Version: | 6.x-1.x-dev |
| Component: | Code feedapi_node |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
| Issue tags: | Performance |
Description
This patch changes _feedapi_node_save (by moving the x_dupe code higher) so that it checks the existence of duplicates before creating a new node object. And also FALSE is returned to indicate that the item is updated when there are duplicates.
#1
patch
#2
It does make sense.
I tested it with simpletest tests of FeedAPI and FeedAPI Mapper and it won't hurt :)
Also I tested it manually and it does not break the cross-feed deduping feature.
#3
Committed. Thank you!
#4
Automatically closed -- issue fixed for 2 weeks with no activity.