Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
- fapi conversion: add, edit and delete.
- Better handling of erroneous URLs.
- Status messages added.
- Currently the userfields() check is only applied for adds and not edits - fixed.
- Duplicates aren't checked for during edits - fixed.
- Watchdog messages added.
- Inevitable formatting fixes :P
Please review,
Thanks
-K
Comment | File | Size | Author |
---|---|---|---|
#9 | profile_19.patch | 548 bytes | Zen |
#8 | profile.module_18.patch | 3.46 KB | yched |
#2 | profile.fapi_inc_2.patch | 10.95 KB | Zen |
#1 | profile.format_2.patch | 33.17 KB | Zen |
profile.fapi_2.patch | 34.16 KB | Zen | |
Comments
Comment #1
Zen CreditAttribution: Zen commented^ : If someone can fix the missing tag, please do so.
I've also broken down the above patch into 2. Attached: the formatting only patch.
-K
Comment #2
Zen CreditAttribution: Zen commentedThe conversion and fixes (only) are in this patch.
-K
Comment #3
Zen CreditAttribution: Zen commentedum, and #2 assumes that #1 has been committed. Or only #0 can be used :) Hope this doesn't confuse anybody :D
-K
Comment #4
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedI have committed #1, please somebody test #2.
Comment #5
merlinofchaos CreditAttribution: merlinofchaos commented#2 works.
Comment #6
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedapplied
Comment #7
yched CreditAttribution: yched commentedThere's a bug in the committed patch :
when you edit a selection field, you don't get the 'selection options' textarea.
The $type variable used in function profile_field_form to identify the field type is not set.
(everything OK for field creation form though)
Comment #8
yched CreditAttribution: yched commentedIf it's not set, just set it :-)
(that one was simple...)
The included patch is against current HEAD - thus after patch "#2" above
Comment #9
Zen CreditAttribution: Zen commentedCheers yched. Patch attached.
-K
P.S Please use the critical priority with a little more caution.
Comment #10
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedapplied
Comment #11
yched CreditAttribution: yched commentedWell, you're probably right about the 'critical' thing,
but when I first posted about the bug, I didn't realized it would be that trivial to fix, and I didn't think I would patch it myself.
I guess I panicked :-)
Comment #12
Zen CreditAttribution: Zen commentedIt seems we need a CVS for the issue queue :)
Cheers,
-K
Comment #13
yched CreditAttribution: yched commentedSorry to be such a pain in the *,
but I just noticed Zen posted his own version of my patch - no ego issue here, that's not my point :-).
Then I saw that was probably because my patch file had a lot of additional lines apart from the one-line fix itself.
That is indeed because there are currently several "non empty" blank lines, ie trailing spaces, in profile.module,
which my editor automatically trims.
According to 'coding style' hints, I guess it would be better to remove those trailing spaces. They parasite file comparisons.
OK - a lot of words for a minor point...
Comment #14
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedyched: I actually thought you'd be introducing blanks (I didn't look that closely). You are right that blanks shoudl be avoided. However, it is best to do a cleanup once in a while than to add reformatting to bug fixes.
Comment #15
yched CreditAttribution: yched commentedI agree with you. These extra lines accidentally slipped in - I should have checked my patch file.
Comment #16
Zen CreditAttribution: Zen commented