• fapi conversion: add, edit and delete.
  • Better handling of erroneous URLs.
  • Status messages added.
  • Currently the userfields() check is only applied for adds and not edits - fixed.
  • Duplicates aren't checked for during edits - fixed.
  • Watchdog messages added.
  • Inevitable formatting fixes :P

    • Please review,
    Thanks
    -K

CommentFileSizeAuthor
#9 profile_19.patch548 bytesZen
#8 profile.module_18.patch3.46 KByched
#2 profile.fapi_inc_2.patch10.95 KBZen
#1 profile.format_2.patch33.17 KBZen
profile.fapi_2.patch34.16 KBZen

Comments

Zen’s picture

Zen commented
StatusFileSize
new profile.format_2.patch33.17 KB

^ : If someone can fix the missing tag, please do so.

I've also broken down the above patch into 2. Attached: the formatting only patch.

-K

Zen’s picture

Zen commented
StatusFileSize
new profile.fapi_inc_2.patch10.95 KB

The conversion and fixes (only) are in this patch.

-K

Zen’s picture

Zen commented

um, and #2 assumes that #1 has been committed. Or only #0 can be used :) Hope this doesn't confuse anybody :D

-K

killes@www.drop.org’s picture

killes@www.drop.org commented

I have committed #1, please somebody test #2.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Reviewed & tested by the community

#2 works.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Reviewed & tested by the community » Fixed

applied

yched’s picture

yched commented
Priority: Normal » Critical
Status: Fixed » Needs work

There's a bug in the committed patch :
when you edit a selection field, you don't get the 'selection options' textarea.

The $type variable used in function profile_field_form to identify the field type is not set.

(everything OK for field creation form though)

yched’s picture

yched commented
Status: Needs work » Needs review
StatusFileSize
new profile.module_18.patch3.46 KB

If it's not set, just set it :-)

(that one was simple...)

The included patch is against current HEAD - thus after patch "#2" above

Zen’s picture

Zen commented
Priority: Critical » Normal
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new profile_19.patch548 bytes

Cheers yched. Patch attached.

-K
P.S Please use the critical priority with a little more caution.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Reviewed & tested by the community » Fixed

applied

yched’s picture

yched commented
Status: Fixed » Reviewed & tested by the community

Well, you're probably right about the 'critical' thing,
but when I first posted about the bug, I didn't realized it would be that trivial to fix, and I didn't think I would patch it myself.
I guess I panicked :-)

Zen’s picture

Zen commented
Status: Reviewed & tested by the community » Fixed

It seems we need a CVS for the issue queue :)

Cheers,
-K

yched’s picture

yched commented

Sorry to be such a pain in the *,
but I just noticed Zen posted his own version of my patch - no ego issue here, that's not my point :-).

Then I saw that was probably because my patch file had a lot of additional lines apart from the one-line fix itself.

That is indeed because there are currently several "non empty" blank lines, ie trailing spaces, in profile.module,
which my editor automatically trims.

According to 'coding style' hints, I guess it would be better to remove those trailing spaces. They parasite file comparisons.

OK - a lot of words for a minor point...

killes@www.drop.org’s picture

killes@www.drop.org commented

yched: I actually thought you'd be introducing blanks (I didn't look that closely). You are right that blanks shoudl be avoided. However, it is best to do a cleanup once in a while than to add reformatting to bug fixes.

yched’s picture

yched commented

I agree with you. These extra lines accidentally slipped in - I should have checked my patch file.

Zen’s picture

Zen commented
Status: Fixed » Closed (fixed)