Posted by Bevan on July 31, 2009 at 5:38am
5 followers
| Project: | Salesforce Suite |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
There is no way to change the sync to salesforce automatically checkbox once a field map has been created. The checkbox should be available on the fieldmap-edit form in order to enabledisable automatic syncing.
Comments
#1
Corrected description: There is no way to change the "sync to salesforce automatically" checkbox once a field map has been created. The checkbox should be available on the fieldmap-edit form in order to enable/disable automatic syncing.
#2
I think it might be better to move that checkbox into the fieldmap/#/edit page altogether, instead of having it in both the add and edit pages, since it doesn't seem to me that knowing whether you want to sync the data is necessary to create the fieldmap.
#3
legion80, agreed.
#4
Attached is a patch to correct this issue.
It's made against salesforce-6.x-2.x-dev, from Sep-01-2009 (latest available for download as of this writing). Something along these lines has been on my todo list for a while. It follows the method described in comment #2.
#5
Thanks!
#6
Wanted to verify that this works. When can we see this patch pushed to the -dev branch?
#7
I had intended to mark the issue "needs review", and not "RTBC" in comment #5.
legion, it's not clear whether you tested this patch or not, or what – specifically – you tested with the patch. please clarify and feel free to change the issue status to RTBC if you think that is valid.
#8
I have verified that the UI checkbox has moved from the "fieldmap add" page to the "fieldmap edit" page. I can also verify that changing the value of the checkbox properly adjusts the "automatic" column in the fieldmap SQL table.
Has anyone else tried the patch? I personally was wondering at point any given patch can move to RTBC--as in, how large "C" needs to be before it is approved.
#9
Great! For simple patches one good review by a confident drupal dev is enough. More reviews are generally needed respective of the complexity of the bug/patch. Basically, if you think that it's ready to be committed, AND you think that the maintainer/s will probably agree with you, then you can mark it RTBC.
As a maintainer, I'd need to either;
before I commit it.
Since I barely have time to address the list of issues marked RTBC for salesforce, let alone the patches needing review or work, I'll leave this on "needs review" for now.
Thanks for your review though, much appreciated!
#10
I tested and verified legion80's results from comment #8
This is good to go - let's get it in!
#11
committed http://drupal.org/cvs?commit=330856
#12
Automatically closed -- issue fixed for 2 weeks with no activity.