Create own settings page under admin/settings/login_security

If every module that got enabled set a message about configuring it, I could easily drown in messages on the refresh. Moreover, if each one of them had a link and I clicked a different one than this one, then this is pointless. I'd much rather get an agreeable set of default settings.

Well, i took this idea from Organic Groups, which is even worse: it points to the README.txt... I don't actually think a lot of modules are doing this and I think it's appropriate specifically for this module because it's not obvious where the configuration settings are... I spent a good few minutes looking for the damn settings for this module (it's not even in the "By module" page...) before resorting to the README.

And I actually feel that it's not a problem if all modules do this. It's pretty rare you enable all modules at the same time, so this is actually pretty safe.

"It's pretty rare you enable all modules at the same time,"

This happends at installation time using a profile, or when you install a set of module you know you will use. This is pretty common, or hte people I know, even I, use to do.

I agree also in other "common" way of doing, after wasting some time you did go to the readme: this one we don't do. But this is my fault, as I know there's a missing handbook page I would write one day. I just asked about changing the settings to it's own page on June 19th #496446: Administration interface tough love, but as nobody cared about that (just deekayen) I agree with him if hi likes where it is. We can get this question asked again from RC to 1.0 if you want, but as it's clearly stated in the README file there's no reason to make it "urgent".

On the other hand, it's a little change and I see no reason why not to include, so we have to decide :)

Ok, no answer for days, I guess this one is not important, so I move to -dev to be reviewed in the last stint..

If we are going to show a message after module installation, IMO the message would also include a link to the handbook page for documentation. Something more like:

"Login security module enabled, head to !settings for configuration or !handbook for documentation and usage. Don't forget to review the README file included in the module package."

Comments?

Reallym this is a bit related with #536954: Improve inline documentation of admin interface: I think the module's documentation can all be self-contained. The settings can be easily self-documented as described in that other bug report, and once the user finds the settings page (which is the issue here), everything goes well.

The issue here is finding the settings page. I see two solutions:

1. have a message pointing to the settings page
2. move the module's settings to its own page

I would prefer 1, but I agree it will cause problems in install profiles as more and more people adopt the module (which I hope happens). I also agree it could be considered bad practice if all modules started doing that. My reflex was to look in the 'by module' settings page, so maybe it should get its own settings page. Another option would be a submenu in the user/permissions stuff.. Not sure.

I am of the opinion, however, that the current situation is really undesirable and needs to be changed. A README change will not suffice.

Hi Anarcat, doing "2. move the module's settings to its own page" is a pretty simple change we can afford in minutes.. We can also include a reference in the current "user settings" page for old user to be aware of the new settings location.

I would preffer to hear also deekayen's opinion, but drupalished styled would say 2nd also..

Maybe we can prepare a single patch to cover this and the other one (include readme explanations in admin interface)..

Once we get #536954: Improve inline documentation of admin interface commited I'll put the admin pages in other file and point a menu entry into admin/settings/login_security. I guess this should avoid more issues like this one (even if it was the first ;) ).

I've moved the administration form to it's own admin/settings/login_security settings page. The permission required to configure login_security has changed from 'administer users' to 'administer site configuration'. I've create an admin.inc file for this.

This is something to be done ASAP.

I have updated the README to notice the new location of the settings form.

Commited to 6.x-1.x-dev

Automatically closed -- issue fixed for 2 weeks with no activity.