When you use the administration theme, there is one [hr] added in the bottom. Is there any specific reason for this line, other then to close the body? As it might look oke on listing pages, on forms its looking a bit akward.

CommentFileSizeAuthor
#4 footer-cruft.patch603 bytesgábor hojtsy
#4 LoginOld.png21.12 KBgábor hojtsy
#4 LoginNew.png20.01 KBgábor hojtsy
last_line.png13.78 KBBojhan

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

The body also has a minimal height of 180px we might also want to loose.

Bojhan’s picture

Bojhan commented

Yhea, saw that - not sure how that looks on the overlay though.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Component: base system » Seven theme

Recomponentize.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Last line in Administration theme » Min-height and bottom border in administration theme
Status: Active » Needs review
StatusFileSize
new LoginNew.png20.01 KB
new LoginOld.png21.12 KB
new footer-cruft.patch603 bytes

Let's get both fixed at once. The bottom border was due to a top border on the footer which also has some whitespace in there even if it does not contain anything (which is normally how it is). So I'd say we should remove the styles for it. The #footer container is only used for the feed icons, and not as a block region. Also, without this patch, the user login 403 screen looks kind of odd, but with this patch, it almost looks normal (it could use quite some love admittedly).

If the overlay needs some kind of min-height (which I'm not at all sure about), the overlay issue can still fix the theme. Overlay styles are walled off under body#overlay anyway.

Access denied out of the box without the patch:

After patch:

Bojhan’s picture

Bojhan commented
Status: Needs review » Reviewed & tested by the community

Discussed with Mark, RTBC

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice clean-ups!

Committed to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.