Default "remember_me_checkbox " setting is inconsistent
joelstein - July 31, 2009 - 21:31
| Project: | Remember me |
| Version: | 6.x-2.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | reviewed & tested by the community |
Jump to:
Description
The config setting "remember_me_checkbox" defaults to 1 on the "admin/settings/remember_me" form, yet it defaults to 0 in remember_me_insert_checkbox(). Thus, the default value for the remember me checkbox on login forms is unchecked if you never actually submit the settings form.
The attached patch solves this by setting the default value to 1 in remember_me_insert_checkbox().
| Attachment | Size |
|---|---|
| remember_me.inc_.patch | 427 bytes |
#1
#2
Makes sense. Whether or not it should be checked by default is debatable though.
#3
I'm fine with either unchecked by default, or checked by default. Just as long as the defaults are consistent. :)