The config setting "remember_me_checkbox" defaults to 1 on the "admin/settings/remember_me" form, yet it defaults to 0 in remember_me_insert_checkbox(). Thus, the default value for the remember me checkbox on login forms is unchecked if you never actually submit the settings form.

The attached patch solves this by setting the default value to 1 in remember_me_insert_checkbox().

CommentFileSizeAuthor
remember_me.inc_.patch427 bytesjoelstein

Comments

joelstein’s picture

joelstein commented
Title: Default config settings are not consistent » Default "remember_me_checkbox " setting is inconsistent
fp’s picture

fp commented
Status: Active » Reviewed & tested by the community

Makes sense. Whether or not it should be checked by default is debatable though.

joelstein’s picture

joelstein commented

I'm fine with either unchecked by default, or checked by default. Just as long as the defaults are consistent. :)

doq’s picture

doq commented
Assigned: Unassigned » doq
Status: Reviewed & tested by the community » Fixed

Committed to 2.x-dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.