Broken drupal_static() conversion in theme_comment_post_forbidden() [#537056]

Comment	File	Size	Author
#6	537056-6.theme_comment_post_forbidden_static.patch	1.51 KB	dww
#1	comment.patch	1.38 KB	catch
#1	patch.png	74.8 KB	catch
	comments.png	207.49 KB	catch
	nodes.png	234.59 KB	catch

Comment #1

he/him

English

commented 31 July 2009 at 23:35

Title:	user_roles() has no static cache	» Broken drupal_static() conversion in theme_comment_post_forbidden()
Component:	user system	» comment.module
Issue tags:	-Needs backport to D6

Status	File	Size
new	patch.png	74.8 KB
new	comment.patch	1.38 KB

OK this is just as broken, but for different reasons, just a bad drupal_static() conversion in comment.module.

Log in or register to post comments

Comment #2

catch

he/him

English

commented 31 July 2009 at 23:37

Status:

Active

» Needs review

Log in or register to post comments

Comment #3

2 September 2009 at 01:15

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Log in or register to post comments

Comment #4

catch

he/him

English

commented 2 September 2009 at 02:37

Status:

Needs work

» Needs review

orly.

Log in or register to post comments

Comment #5

catch

he/him

English

commented 23 October 2009 at 01:52

Issue tags:

+Quick fix

umm, bump?

Log in or register to post comments

Comment #6

dww

we/he/they

commented 28 October 2009 at 08:28

Status	File	Size
new	537056-6.theme_comment_post_forbidden_static.patch	1.51 KB

catch asked me to review this in IRC. While the previous code was clearly broken, we don't actually need to avoid using drupal_static() entirely, we just need to use it properly. ;) If we initialize the static as NULL, we can test !isset() and set the real value for the variable. Also cleaned up the code comments a bit to clarify.