Here we go

I've prepared to introspect nodereferrers details and right started away with fixing all coder complains for codestyle reasons. Going to review it soon deeper if codestyle is applied.

Provided patch changes all codestyle to recommendet situation as of now.

Hope you agree!

CommentFileSizeAuthor
#4 nodereferrer_codestyle.patch21.72 KBmiro_dietiker
#2 nodereferrer_codestyle.patch21.17 KBmiro_dietiker
nodereferrer_codestyle.patch10.22 KBmiro_dietiker

Comments

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Active » Needs review

ready to review for sure!

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
StatusFileSize
new nodereferrer_codestyle.patch21.17 KB

forgot -up options ... this time in unified diff style

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Needs review » Needs work

Hey.
Looks much better now but I still have some notes:

nodereferrer.module
@@ -3,6 +3,7 @@
 
 
 
+ * 
 /**
  * @file

Where does these empty lines come from? And why this single "*" right before the comment start?

@@ -345,12 +347,12 @@ function nodereferrer_content_is_empty
Comments are full sentences and should be closed with a period. This applies to all comments.
@@ -384,7 +386,7 @@ function nodereferrer_referrers
I'm not happy with this indentation of the SQL-statement. But that's just a personal feeling.
@@ -37,8 +42,8 @@ class nodereferrer_view_handler_argument
+        '#collapsible' => 'TRUE',
+        '#collapsed' => 'TRUE',

This is wrong. Use TRUE (the constant) and not the string 'TRUE'.

@@ -45,8 +50,8 @@ class nodereferrer_view_handler_field
same as above
@@ -45,8 +50,8 @@ class nodereferrer_view_handler_filter
same as above

happy patching :-)

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
StatusFileSize
new nodereferrer_codestyle.patch21.72 KB

Back again.. Thanks for reviewing!
Corrected issues, SQL statement left untouched.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs work » Needs review

my friend: status change ;-)

andypost’s picture

andypost
he/him
Primary language Russian
commented

Thanx, I will commit this latter with #416332: Option in views to only display the number of referrers node ( count the child node of a cck node and display the number )

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Fixed

Thanx, commited to 6-dev

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

cool. thx.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.