Home » Download » Modules » NodeReferrer » Issues

Codestyle update

miro_dietiker - August 1, 2009 - 02:44
Project:NodeReferrer
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Here we go

I've prepared to introspect nodereferrers details and right started away with fixing all coder complains for codestyle reasons. Going to review it soon deeper if codestyle is applied.

Provided patch changes all codestyle to recommendet situation as of now.

Hope you agree!

AttachmentSize
nodereferrer_codestyle.patch10.22 KB
» Login or register to post comments

#1

miro_dietiker - August 1, 2009 - 02:47
Status:active» needs review

ready to review for sure!

Login or register to post comments

#2

miro_dietiker - August 4, 2009 - 06:15

forgot -up options ... this time in unified diff style

AttachmentSize
nodereferrer_codestyle.patch 21.17 KB
Login or register to post comments

#3

stBorchert - August 4, 2009 - 06:57
Status:needs review» needs work

Hey.
Looks much better now but I still have some notes:

nodereferrer.module
@@ -3,6 +3,7 @@



+ *
/**
  * @file

Where does these empty lines come from? And why this single "*" right before the comment start?
@@ -345,12 +347,12 @@ function nodereferrer_content_is_empty
Comments are full sentences and should be closed with a period. This applies to all comments.
@@ -384,7 +386,7 @@ function nodereferrer_referrers
I'm not happy with this indentation of the SQL-statement. But that's just a personal feeling.
@@ -37,8 +42,8 @@ class nodereferrer_view_handler_argument
+        '#collapsible' => 'TRUE',
+        '#collapsed' => 'TRUE',

This is wrong. Use TRUE (the constant) and not the string 'TRUE'.
@@ -45,8 +50,8 @@ class nodereferrer_view_handler_field
same as above
@@ -45,8 +50,8 @@ class nodereferrer_view_handler_filter
same as above

happy patching :-)

Login or register to post comments

#4

miro_dietiker - August 4, 2009 - 07:08

Back again.. Thanks for reviewing!
Corrected issues, SQL statement left untouched.

AttachmentSize
nodereferrer_codestyle.patch 21.72 KB
Login or register to post comments

#5

miro_dietiker - August 4, 2009 - 07:19
Status:needs work» needs review

my friend: status change ;-)

Login or register to post comments

#6

andypost - September 22, 2009 - 10:06

Thanx, I will commit this latter with #416332: Option in views to only display the number of referrers node ( count the child node of a cck node and display the number )

Login or register to post comments

#7

andypost - September 22, 2009 - 11:16
Status:needs review» fixed

Thanx, commited to 6-dev

Login or register to post comments

#8

miro_dietiker - September 22, 2009 - 11:21

cool. thx.

Login or register to post comments

#9

System Message - October 6, 2009 - 11:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

Login or register to post comments
 
 

Drupal is a registered trademark of Dries Buytaert.