right now
example.com/a_b_c?d=1
example.com/a_b?c_d=1
would result in the same filename
../example.com/a_b_c_d=1.html

The simple fix might be to exchange the ? for 3 _ instead of 1.
example.com/a_b_c?d=1 - ../example.com/a_b_c___d=1.html
example.com/a_b?c_d=1 - ../example.com/a_b___c_d=1.html

Thoughts?

CommentFileSizeAuthor
#6 boost-537186.patch10.82 KBmikeytown2
#4 boost-537186.1.patch17.68 KBmikeytown2
#1 boost-537186.patch8.65 KBmikeytown2

Comments

mikeytown2’s picture

mikeytown2 commented
Status: Active » Needs review
StatusFileSize
new boost-537186.patch8.65 KB

just tested and === works; it's something that almost no one will use in a URL from what I can tell
http://www.google.com/search?q=%22%3D%3D%3D%22
http://www.bing.com/search?q=%22%3D%3D%3D%22
http://search.yahoo.com/search?p=%22%3D%3D%3D%22

eagereyes’s picture

eagereyes commented

Why not simply keep the question mark in the file name? It's a perfectly legal character, and that would solve the problem.

mikeytown2’s picture

mikeytown2 commented

? is not a legal character for filenames on windows.
http://en.wikipedia.org/wiki/Filename#Reserved_characters_and_words

mikeytown2’s picture

mikeytown2 commented
StatusFileSize
new boost-537186.1.patch17.68 KB
mikeytown2’s picture

mikeytown2 commented
Priority: Normal » Minor
Status: Needs review » Needs work

Change this so it can take user input on what to replace ? with. Let the admin choose.

mikeytown2’s picture

mikeytown2 commented
Status: Needs work » Needs review
StatusFileSize
new boost-537186.patch10.82 KB

It's now a Global variable instead of ===

mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Fixed

committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.