ForexFeed [forexfeed]
ForexFeed - August 1, 2009 - 05:55
| Project: | Drupal.org CVS applications |
| Component: | Miscellaneous |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
Hello,
We've created a new module and would like to contribute it to the community.
This module displays real-time currency quotes (aka FOREX) in configurable block(s), it is designed to operate in conjunction with the data services of forexfeed (dot) net.
Thank you.

#1
#2
#3
<?php'#title' => l('ForexFeed.net', 'http://forexfeed.net', array('attributes'=>array('target'=>'_blank')) ) .' '. t('Access Key'),
?>
I am not sure you can use HTML tags for the title of a textfield; it seems more appropriate to add a link in the description for the form field (or in the help for the page).
<?php
/** ForexFeed.net Access Key */
function _forex_feed_get_access_key(){
return variable_get('forex_feed_access_key', '');
}
/** Number of available Blocks */
function _forex_feed_get_num_blocks(){
return variable_get('forex_feed_num_blocks', 1);
}
?>
It would be better to use directly
variable_get().#4
Thanks for the review. Admin function and the variable wrappers have been refactored.
#5
#6
#7
#8
Sorry, was missing the // $Id$ comment tag. Thanks again.
#9
#10
Automatically closed -- issue fixed for 2 weeks with no activity.