ForexFeed [forexfeed]

ForexFeed - August 1, 2009 - 05:55
Project:Drupal.org CVS applications
Component:Miscellaneous
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Description

CVS edit link for ForexFeed

Hello,

We've created a new module and would like to contribute it to the community.

This module displays real-time currency quotes (aka FOREX) in configurable block(s), it is designed to operate in conjunction with the data services of forexfeed (dot) net.

Thank you.

#1

ForexFeed - August 1, 2009 - 05:57
AttachmentSize
forex_feed.tar_.gz 69.17 KB

#2

ForexFeed - August 1, 2009 - 06:02
Status:postponed (maintainer needs more info)» needs review

#3

kiamlaluno - August 1, 2009 - 13:35
Status:needs review» needs work
  1. <?php
     
    '#title'         => l('ForexFeed.net', 'http://forexfeed.net', array('attributes'=>array('target'=>'_blank')) ) .' '. t('Access Key'),
    ?>

    I am not sure you can use HTML tags for the title of a textfield; it seems more appropriate to add a link in the description for the form field (or in the help for the page).

  2. forex_feed.admin.inc includes only a function; in that case it's probably better to move the code to the module file.
  3. <?php
    /**  ForexFeed.net Access Key  */
    function _forex_feed_get_access_key(){
      return
    variable_get('forex_feed_access_key', '');
    }

    /**  Number of available Blocks  */
    function _forex_feed_get_num_blocks(){
      return
    variable_get('forex_feed_num_blocks', 1);
    }
    ?>

    It would be better to use directly variable_get().

  4. The indentation used should be 2 spaces.

#4

ForexFeed - August 1, 2009 - 17:47

Thanks for the review. Admin function and the variable wrappers have been refactored.

AttachmentSize
forex_feed.tar_.gz 69.06 KB

#5

ForexFeed - August 1, 2009 - 17:47
Status:needs work» needs review

#6

kiamlaluno - August 1, 2009 - 19:43
Status:needs review» needs work
  1. Drupal coding standards are not completely followed.
  2. I would also remove the files that are not necessary in the repository (the license file, and the images that are not used in any places).

#7

ForexFeed - August 2, 2009 - 19:00
Status:needs work» needs review
AttachmentSize
forex_feed.tar_.gz 3.01 KB

#8

ForexFeed - August 2, 2009 - 19:12

Sorry, was missing the // $Id$ comment tag. Thanks again.

AttachmentSize
forex_feed.tar_.gz 3.02 KB

#9

kiamlaluno - August 2, 2009 - 19:13
Status:needs review» fixed

#10

System Message - August 16, 2009 - 19:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.