It was the result of the use of module_rebuild_cache() - see http://drupal.org/node/429132 - and a change in the t() parameters for d7. Tested "drush status" on D6 and D7. See patch.

CommentFileSizeAuthor
#9 drush-d7-update.patch11.97 KBbabbage
#8 drush-537280-6.patch8.88 KBjasonn1234
#6 drush-537280-5.patch8.84 KBjasonn1234
#5 drush-537280-4.patch8.14 KBjasonn1234
#4 drush-537280-3.patch7 KBjasonn1234
#2 drush-537280-2.patch5.68 KBjasonn1234
#1 drush-537280.patch2.9 KBjasonn1234
drush-status-d7.patch1.24 KBjasonn1234

Comments

jasonn1234’s picture

jasonn1234 commented
Title: drush status throws errors / doesn't load in latest d7.x-dev » d7: make drush-status and drush-statusmodules work
StatusFileSize
new drush-537280.patch2.9 KB

I replaced all occurrences of module_rebuild_cache() with the a new function - drush_get_modules() - which conditionally breaks out for D5 & 6 and handles things for D7. Tested on D6 and D7.

Here's drush_get_modules() :

/**
 * Fetch info on all installed modules
 */
function drush_get_modules(){
  if (function_exists('module_rebuild_cache')) {
    // Drupal5 and Drupal6
    $module_info = module_rebuild_cache();
  }
  else {
    $module_info = drupal_system_listing('/\.module$/', 'modules', 'name', 0);
    system_get_files_database($module_info, 'module');
    foreach($module_info as $module_name => $module){
      $module_info[$module_name]->info = drupal_parse_info_file(dirname($module->filename) .'/'. $module->name .'.info');
    }
  }
  return $module_info;
}
jasonn1234’s picture

jasonn1234 commented
Title: d7: make drush-status and drush-statusmodules work » d7: housecleaning - accounting for functions missing or renamed in D7
StatusFileSize
new drush-537280-2.patch5.68 KB

General "housecleaning" of this nature -- accounting for functions missing or renamed in D7.

So far:

(D5 & D6 --> D7)
-------------------
drupal_init_language() --> drupal_language_initialize()
drupal_install_init_database() --> drupal_install_initialize_database()
module_rebuild_cache() --> system_get_files_database()
_system_theme_data() --> _system_get_theme_data()

moshe weitzman’s picture

moshe weitzman commented

Thaks for figuring this out. drush_get_modules() seems to go against the separation that we are doing whereby we have a separate include for each drupal major version ... i'd love for owen to see through these issues related to PM in drush.

it is certainly time we properly support d7. thanks for moving on this.

jasonn1234’s picture

jasonn1234 commented
Issue tags: +D7CX
StatusFileSize
new drush-537280-3.patch7 KB

Okay - I moved made drush_get_modules() and drush_get_themes() into environment.php, and converted them into wrappers which call drush_include_engine() to account for differences between drupal versions.

I added two includes to the /commands/core/drupal directory - environment.inc and environment_7.inc. These two files break out the conditional behavior for drupal5 & 6, and drupal 7, respectively.

jasonn1234’s picture

jasonn1234 commented
StatusFileSize
new drush-537280-4.patch8.14 KB

This patch is better.... a few more details taken care of.

With the attached patch, the following commands work for me in d7:

help | cron | updatedb | status | cache clear | watchdog show | statusmodules | sql *

jasonn1234’s picture

jasonn1234 commented
StatusFileSize
new drush-537280-5.patch8.84 KB

Oof.. sorry... this is getting to be a pretty long patch...

I found another issue #535788: Check sites/all/themes for *.drush.inc files

...that's easy to fix but would be dependent on the drush_get_theme() function introduced in this issue.

So - another version of this patch, this time to fix the above search path issue.

moshe weitzman’s picture

moshe weitzman commented

looks great to me. a code review only found nitpicky stuff:

  1. use 2 space indentation instead of 4
  2. in doxygen, the value of @return goes on a new line and indented 2 spaces.
  3. sentences in doxygen should end in a period.

adrian mentioned that the theme searchpath does not inherit at all commands from base themes. we should remove that feature from this issue.

i'll probably commit the next patch here. feedback welcome.

also, feel free to tackle those narly pm commands.

jasonn1234’s picture

jasonn1234 commented
StatusFileSize
new drush-537280-6.patch8.88 KB

Awesome. Okay - I removed all the theme searchpath stuff related to #535788: Check sites/all/themes for *.drush.inc files and fixed the whitespace issues and doxygen documentation.

babbage’s picture

babbage commented
Title: d7: housecleaning - accounting for functions missing or renamed in D7 » D7 compatibility
Category: bug » task
Status: Needs review » Needs work
StatusFileSize
new drush-d7-update.patch11.97 KB

Having recently discovered drush (why did it take me so long?) can't wait to have a version that works with D7. This patch gets us part of the way there, but when I tested it fairly thoroughly there are still a number of areas that require work.

Firstly, the patch in #8 includes incorrect directory paths due to not being created from CVS and also failed to create the required file: commands/pm/update_info/drupal_7.inc. The attached patch is created against current cvs HEAD and also creates that file, at this stage created to be identical to the D6 one; this file needs to be present for update to work. .

Successfully ran and tested as working:
help
cron (drush reported success; not independently confirmed)
updatedb
status
statusmodules
refresh
update (Does not return errors. Without official D7 releases of modules difficult to demonstrate it fully works?)
dl
test mail
test clean
sql conf
generate taxonomy

Errors found:
watchdog delete all

PHP Fatal error: Call to undefined function db_affected_rows() in /Applications/Drush/commands/core/core.drush.inc on line 429
Drush command could not be completed.

enable [module]: failed to display the prompt ,"The following modules will be enabled: cck
Do you really want to continue? (y/n):". Instead, displayed a blank line. If enter is pressed, it aborts; if "y" submitted, then reports all of "The following modules will be enabled: cck. Do you really want to continue? (y/n): CCK Field UI was enabled successfully." Clearly drush is waiting for the usual user input but is no displaying the user prompt until after the user submits their response. This error is seen in enable, disable and uninstall. CCK used as example but same problems seen with other modules.

enable:

Warning: array_filter(): The second argument, '_drupal_install_module', should be a valid callback in [warning]
module_enable() (line 241 of /Development/drupal.org.nz/includes/module.inc).

In some cases (e.g. CCK) the module is still correctly enabled. In other cases (e.g. admin_menu, charts) the module is not successfully enabled. Both of these modules can be enabled through the usual module admin interface suggesting it is not (solely) due to module code that they are failing to be enabled.

uninstall: always fails.

Drush command could not be completed. [error]

drush info [modulename]:

PHP Fatal error: Class 'update_xml_parser' not found in /Applications/Drush/commands/pm/update_info/drupal_7.inc on line 82
Drush command could not be completed.

generate users [#ofusers]: Appears to correctly generate the requested number of users, but outputs pages and pages of rubbish output before reporting success. e.g.

??p<{vؘ??WΎ?]??W/c??_9D??td???@?傳?????]1;?ݨ?û?=Wp?2??$Ǚ?????v?????D?ټ`zpٹ???6[??O<?????~<???L????5?l???9????S???<?p??Ǯ?~??????????+}0p
" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!" D@??!"

generate content [#_of_nodes] [#_comments_per_node]: Reports Generated 5 nodes, 30 comments per node. However, while the nodes are created, the comments are not.

Not tested:
script (no examples to hand to test)
sync (not set up to test this currently)
eval
updatecode
sql connect
sql dump
sql query
sql load
sql cli

moshe weitzman’s picture

moshe weitzman commented
Assigned: Unassigned » owen barton

Would love owen and adrian's review. There is a little architecture changing here (environment include). From my perspective, we should commit this and keep fixing bugs (especially note the pm commands).

moshe weitzman’s picture

moshe weitzman commented
Status: Needs work » Fixed

Committed this fine patch and fixed watchdog delete. Lets focus on updating the pm commands like info, enable, disable, ...

jasonn1234’s picture

jasonn1234 commented

Excellent! Yes - I'll happily take a look at the pm commands as soon as I get my head above water again...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

moshe weitzman’s picture

moshe weitzman commented

Oops. I just committed a drupal_7.inc file which was in this patch. It was in my tree but not checked in. Sorry.