On page admin/build/panels the following strings cannot be translated:
'Create new...'
'Manage mini panels...'
'Manage pages...'

I hope this refers to Panels and not Ctools (which I checked, they don't contain the strings, too).

CommentFileSizeAuthor
#1 panels-unstranslatable-strings.patch1.35 KBdawehner

Comments

dawehner’s picture

Status: Active » Needs review
StatusFileSize
new1.35 KB

Here is a patch which solves this.

FrankT’s picture

Status: Needs review » Active

Unfortunately I'm not very used to patching, and 'patch -pnum

In the meantime I would like you to modify the new strings so that all 3 '...' are within the t() functions to provide more flexibilty in translating. In my case I probably need to put the '...' BETWEEN words (something like 'new ... add').

dawehner’s picture

Status: Active » Needs review

then i suggest to read http://drupal.org/patch/apply

FrankT’s picture

I spent hours to search and test all ways to patch I found on drupal.org but none worked. In this case I think/thought it would be correct to save the patch into sites\all\modules\panels\template and to execute 'patch < panels-unstranslatable-strings.patch' but only a new windows appears executing patch.exe and nothing else happens (no output, just as patch.exe would hang).

I also tried -p0, -pnum, different locations to save the patch before patching, ... (either the patch.exe windows closes immediately or it hangs).

Well, of course I would like to have the patching solved, too. But the next thing to be done in this issue in my eyes should be to put '...' within the t()-function, as mentioned in #2.

dawehner’s picture

i think you use patch wrong

patch -p0 < patchfile.patch

I don't think '...' should be in the t() strings, because the strings could be used with my patch, on other places

FrankT’s picture

I already used patch -p0 < panels-untranslatable-strings.patch from within the templates subdirectory of panels. I causes a frozen patch.exe windows (windows environment, patch.exe from sourceforge).

As you're from germany, how would you translate 'Create new...': If 'Neu erstellen...' would be OK for you, then it's OK to leave '...' out of the t() strings...

dawehner’s picture

by default, every patch should be applied out of root of the module

Yes your translations looks fine, but you have to look at perhaps existing translations :)

merlinofchaos’s picture

Status: Needs review » Fixed

Committed!

Thanks!

FrankT’s picture

Thanks, I'll give it a try from the module's root (although I think I also tried this one). I'm workig on a translation of panels and ctools, based on the translation included in the module so far. If your interested before it's ready please let me know.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.