Posted by rmiddle on August 1, 2009 at 3:59pm
| Project: | Comment closer |
| Version: | 6.x-1.3 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Add an activation button to prevent accidental closing of Comments before an admin has a change to setup there settings.
Comments
#1
Would it not be better to have the fresh install defaults set up so that nothing is changed? It seems that the issue many have is the module installs with defaults that are not wanted by every user.
If you want to keep the defaults, then a checkbox to enable the module is a feature I see with other modules, for example, Boost.
#2
I created a quick module to do this on my sites, and by default, it won't disable any comments until you tell the module which for which node types you'd like to disable comments. This way it's a bit of a safer default.
It's pretty simple, but it gets the job done for my needs.
#3
Considering how long this issue has been open (I understand not having time to work on your module), defaulting to "don't close any comments" is an easier and better option.
A "activate" button would be confusing from a UX perspective. Also, you'd have to track whether that button has ever been pressed; a DX annoyance.
#4
I need to get this one done.
@3 JohnAlbin
My plan was for a simple check box with "Enabled" if checked it runs if not checked it doesn't
Thanks
Robert
#5
Here you go, Robert. It allows "Never" to be a cycle time, and is the default.
#6
Updating title... hard to understand based on the title, still :-/
#7
Works for me.
Have you tested the patch?
#8
Committed to 6.x-1.x-dev
#9
#10
Automatically closed -- issue fixed for 2 weeks with no activity.