Hello,

pardon me for the newbye question, but is normal that the CVS version of the module does not deal with 4.7b5 nor with 4.7cvs?

I installed it on a clean Drupal install, but when i go to settings>location i get following error:

Fatal error: Call to undefined function: form_select() in /public_html/test-site/drupalcvs/modules/location/location.module on line 325

Any chance to have this work?

Help very apreciated since my site is location-based!

thx

Comments

moshe weitzman’s picture

moshe weitzman commented
Category: support » feature

it is not abnormal ... this module begs for someone to post it to 4.7. anyon working on this? if not, anyone available to pay for it?

karens’s picture

karens commented

The conversion was done to HEAD back in Nov (http://drupal.org/node/37964). My copy of the current cvs has all the new form API functions and works fine in 4.7. Maybe you have a 4.6 cvs version??

ankur’s picture

ankur commented

The error described above has to have been the result of using a revision of the module from the DRUPAL-4-6 branch. Location module has been mostly ported to 4.7. The problem is that most of this work was done in November, as mentioned above, but that there has been several changes to the core API since then. In short, I haven't had the chance to check items 24-30 on the list of things that need to be done to make the module 4.7-compatible (see http://drupal.org/node/22218).

I'd like to get around to it, but can't unless the boss says I can. If someone else can verify these last few items for me then I'd be willing to tag HEAD for the 4.7 branch. Those items might not even apply to location module, but I would prefer to verify before I tag the module and say that it works with 4.7.

-Ankur

marcoBauli’s picture

marcoBauli commented

Yes, seems to works now with the HEAD cvs version and 4.7.0b6

thx

nk126’s picture

nk126 commented

I upgraded from 4.6.x to 4.7 yesterday. Location.module seems to be working fine, except that geocoding doesn't work. When I manually enter lat/long info on node creation, it works as it should, parsing out to the XML feeds, etc ... But geocoding (auto lookup of lat/long based on address) doesn't work.

In 4.6, geocoding attempts caused fatal errors because function xmlprc apparently wasn't part of my php install. Now I don't get the errors ... I just don't get anything.

Help?

ankur’s picture

ankur commented

There is a function defined in location.us.inc that can call up geocoder.us, but at the moment, it is not called by the module. This was a project that never got completed: I wrote the function and planned to add an interface that would've allowed the admin to turn on geocoding via geocoder, but that never got done. The reason I don't want to include it automatically (and the reason I want to make it configurable instead) is that the license (non-commercial, share-alike) for using geocoder.us might not match the terms of the drupal site admin that is trying to get address data from geocoder.us.

Ultimately, I want to do something w/ the geocoding options that is similar to how the module works for MapLinking options.

-Ankur

karens’s picture

karens commented

Ankur,

I checked the list of requirements for 4.7 and if you commit the patch at http://drupal.org/node/57910 to add an install file, the location module should qualify as 4.7-ready. You may want to remove the mysql files (except for the big files that add the data to the zipcodes table since those stilll need to be updated manually) so that the install file controls the database structure going forward.

dww’s picture

dww
we/he/they
commented
Status: Active » Closed (fixed)