Closed (won't fix)
Project:
Drupal core
Version:
8.0.x-dev
Component:
comment.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 Aug 2009 at 23:16 UTC
Updated:
29 Jul 2014 at 18:22 UTC
Jump to comment: Most recent file
Comments
Comment #1
mikeytown2 commented+1 Agree
Comment #2
neochief commentedDone. Please support this patch with your review.
Comment #3
neochief commentedChanging the title.
Comment #5
neochief commentedUpdate for TB.
Comment #7
neochief commentedAnother try.
Comment #8
mikeytown2 commentedThere are CR characters in the patch. Also I just tried this out with a brand new D7 install and it doesn't work as advertised. Comments are in the same place as
Display below post or commentswhen I selectDisplay below post, but above comments.Comment #9
neochief commentedDid you cleaned the drupal cache? There is new template file, and if you just patched existing installation it should not work.
Comment #10
mikeytown2 commentedPatched then installed. Cleared the cached and it did nothing.
Comment #11
yched commentedThis is now entirely doable by overriding the content-wrapper.tpl.php template. Might be only me, but adding a UI option for this is overkill IMO. If we go this way, there's a long list of UI options we could add...
Comment #12
neochief commented@mikeytown2, are you sure? I just tested patch on fresh D7 installation, everything works fine.
@yched, yes, agree, It can be done by making a new template (and patch adds this emplate). But I don't think that it's an option for which user should add a template manually.
Comment #13
mikeytown2 commentedFigured out the dumb problem.
patch < comment_form_above_comments_1.patchdumped comment-wrapper-form-above.tpl.php in the drupal root even though it's supposed to go in modules/comment.Attached is the patch without the CR line endings
Comment #14
mikeytown2 commentedpatch works, and its quite useful IMHO.
Comment #15
webchickHrm. Really? You want people commenting without having read the discussion so they repeat the same info other people did? :P That seems like a recipe for annoyance.
I'm tempted to make this a theme-only thing and not expose a UI option for it. Is there a precedent for this elsewhere on the web / other CMSes?
Also, I'm not quite enthusiastic about this implementation. We do not have a comment-wrapper-form-below.tpl.php. Why do we need a comment-wrapper-form-above.tpl.php?
Comment #16
vm commentedthe idea I believe sounds similar to the "quick reply" features found in forums where one doesn't really read the comments of other users but wants to quickly comment on the thread itself.
Comment #17
webchickBut even then, the "quick reply" form is found at the bottom of the comment listing. See phpBB, punBB, etc.
Comment #18
moshe weitzman commentedThis is contrib material, IMO.
agree with webchick that a new template for this is absurd.
Comment #19
vm commentedwebchick, my apologies. don't know why I thougt it was directly after a post. Drupalized too long I guess.
Comment #20
kaakuu commented"Is there a precedent for this elsewhere on the web / other CMSes?"
Probably NO!
Drupal Guestbook module has this feature where it gives the option to place the gb comment form either at top or bottom. Typically the placement of form at the top happens in case of Profile comments like Google's Orkut or other social sites.
The other example of quick comment form is on hover - in blursoft's forum script you can read the last comment on hover over the last commentor's name in the topic list, and reply on hover too without the need to open a thread which you already have been following. That is their unique nifty core feature.
Drupal already has excellent comment form options in core, and contribs like "talk" extend that to almost all the possibilities a CMS can have :)
I do not feel we need a comment form at the top.
Comment #21
robloachHaving the form at the top of the comment content is slowly becoming a standard among social websites. Some examples of large sites that have the comment form at the top:
Since we already have the option to stick it either under the comments, or on another page, it makes sense to also have an option to put it at the top of the comments. Drupal's Comment module needs as much help as it can get, and this would be a great addition. The past two websites I've worked on, the client has asked for this feature. Definitely is core-worthy.
Comment #23
Cory Goodwin commentedI agree that this should be an option. The "Add new comment" link is already at the top directly under the node. The philosophy of not forcing the reading to scroll through the other comments if the reader only wants to respond to the node is already ingrained in Drupal.
Comment #24
johnalbinWe missed code freeze.
Given the way comment-wrapper.tpl.php works, you won't be able to implement this feature as a contrib module without overriding the default comment-wrapper template. Which may cause incompatibilities with some themes' styles.
Comment #25
johnalbinActually, this is a better way to fix this problem, IMO: http://drupal.org/project/commentblock
:-)
Comments and comment form as blocks might be core-worthy. Not crazy about this issue. I hope no one minds me "won't fix"ing it since its already fixed in contrib. :-)
Comment #27
gynekolog commented#7: comment_form_above_comments.patch queued for re-testing.
Comment #28
gynekolog commented#13: comment-539216.patch queued for re-testing.
Comment #31
korund commented#13: comment-539216.patch queued for re-testing.
Comment #33
gansbrest commentedHere is my quick and relatively dirty solution for this (Drupal 6):
Copy comment-wrapper.tpl.php to your theme if you don't have it there already and then slightly modify it:
The idea is to separate form html from the comments area and attach it to the top later on.
Works pretty good, no need to patch core, but I agree - the comment module is sort of strange / messy and that functionality should be in core at some point.
Comment #34
gynekolog commentedworks, thank you!
Comment #35
vm commentedremarking won't fix per #25
Comment #36
devkinetic commentedFWIW, I'd like to not have to install another module for this. I see no reason why the theme function cannot output two variables; one for the form, another for the comments.
I'm using D6 and took the code from #33 and implemented it from within template.php.
This should be the preferred method over putting this code in the template file.