Needs review
Project:
UC Multiprice
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
4 Aug 2009 at 03:41 UTC
Updated:
18 Apr 2011 at 14:37 UTC
Jump to comment: Most recent file
Comments
Comment #1
Docc commentedThere are no global settings for multiprice.
Wich version of Drupal are you using? anything in your error log? and does this happens in multiple browsers?
Comment #2
HansR commentednothing in the error log
happens in Internet Explorer, which still represents 95% of visitors...
Using Drupal 6.9 , going to upgrade soon.
Comment #3
HansR commentedComment #4
Docc commentedk i tried it in IE 8 the other day and got the js error.
After some debugging it seems the POST from the ajax call is empty. I really have no clue why this is happening and it only occurs in IE. Ill check back if i know something more.
Comment #5
HansR commentedyes... Ajax doesn't seem to do what it needs to do in IE... :-(
But as I said... unfortunately... 95% of my visitors still use IE, so can no just ignore it.
but thanks for looking into it. Looking forward to some feedback soon.
Comment #6
Docc commentedProblem is only on the node/product edit form. So "visitors" wont be bothered by it.
Comment #7
HansR commentedyes, I understand that... but I need to be able to add it to the site right ? Aslong as I can not add it... No point having it...
Comment #8
heavy_engineer commentedI can confirm this on Linux FF3 and Chrome. I get a JS alert:
And line 484 (CVS Head) and 456 (Dev + stable (from memory)) goes like this:
$form['multiprice']['countries'] += $field;in this code block:
Im going to attempt to work out whats up - from what i've read its an ahah form issue, something to do with the way the forms are cached and then redisplayed. It doesnt appear to be a js error tho, although the error message is in a js alert.
If anyone listening knows more than i do, please point me in the right direction. Will post back if i get anywhere with it.
Comment #9
heavy_engineer commentedI cant get this any further forward.
seems $form['multiprice']['countries'] is not an array (which it should be).
**Snip**
After much toing and froing i did get it kind of working but, the way the module interacts with the new price api (i.e. i dont think it knows about it) is causing this problem. If i set the values in the db it works well, but the currency is formatted incorrectly - as the default, e.g. £ instead of $.
The ahah stuff is kind of a red herring. i think
Comment #10
timl commentedmake sure if you are using the 'devel' module that it isn't writing stuff to the bottom of each request (i.e. page generation time). I had that switched on and was getting js issues with this module.
Comment #11
william.lai commentedWe have the same issue and always get following message in IE:
-------------------------------------
An error occurred.
/uc_multiprice/js
(no information avaliable)
-------------------------------------
It seem that the $_POST variable always empty after received in server side.
There is no problem in firefox.
During the checking, we found a php issue seem related to enctype="multipart/form-data" and POST.
http://bugs.php.net/bug.php?id=26004
But no idea on how to fix it.
Thanks.
Comment #12
zbrooks commentedI was also able to resolve this by disabling Devel, might bare looking into though.
Comment #13
smartsystems160 commentedI have this error too in IE, Mozilla, Chrome, and Opera, but none of this error shows up when i use my admin account to set the multiprice. It only happens with my seller accounts which means its a real problem if i am offering multiseller ability. I guess something needs to be done about this. But Great module. Thanks and hoping this is good info for you to work on...
Comment #14
Docc commentedHey guys,
Seems i added the permission "administer nodes" to the AJAX callback.
So if the user does not have that permission the call will fail.
Ill fix this in the next week.
Anyone having this issue as user 1?
Comment #15
smartsystems160 commentedHi Docc,
user 1 is ok for me. I noticed something else in this dev version. Nigeria is conspiciously absent among the list of countries, dont know if there are any other countries absent in the list. Sorry i am not a coder at all, so dont know if its from my setting or not. Just hope you look it up too. Thanks. waiting for the patch.
Comment #16
Docc commentedDid you enabled the country on the countries admin screen? "admin/store/settings/countries"
Comment #17
smartsystems160 commentedYes i enabled all countries. Infact, i was using the previous stable version before the dev version and all countries were displayed. but when i installed the dev, i noticed it. All other countries were displayed.
Comment #18
smartsystems160 commentedHi Docc,
Just wanted to ask if there is progress on this work....
Thanks
Comment #19
Docc commentedChanging version to 2.x. This is where its all happening now. Ill only do security fixes for 1.0
Commited a fix to the dev branche. Check it out and let me know if its working for you all.
Remember to clear the cache/rebuild menu
Comment #20
smartsystems160 commentedI have installed the module and tested it, same javascript error, but this time, ERROR ALSO HAPPENS FOR USER 1. The previous error happened to only users apart from 1. still didnt see Nigeria in 'add price override for a country' when creating product or using Multprice defaults UI in store admin->configurations.
Updated: error code: An HTTP error 404 occurred.
/Platform/uc_multiprice/js/
Comment #21
Docc commentedDid you rebuild the menu / clear cache?
Comment #22
smartsystems160 commentedYes i rebuilt the menu / cleared cache as you instructed
Comment #23
Docc commentedWeird, there should be a nid at the end of uc_multiprice/js/
Ill see if i can reproduce the error.
Comment #24
Docc commentedk found the problem. Commited 2 permissions to dev: 'administer multiprice' and 'create & edit multiprices'
Set the right permissions for your users. Let me know if it works for you. (ps clear cache again)
Comment #25
Docc commentedComment #26
lpalgarvio commentedstill having the same error, when having Devel enabled and configured to display memory usage and/or page timer.
If you have the page timer and memory usage from Devel disabled, no error occurs.
Also no error occurs/there is no change in the error by having Caching, Block caching, Page compression, CSS/JS Gziping and aggregation set to ON or OFF. It does not affect or interact with Devel for that matter.
The problem should be a conflict in function names or variables between UC Multiprice and Devel in the javascript.
using the latest UC Multiprice 2.x-dev
re-opening issue.
Comment #27
Docc commentedAdding a devel_exit() to the uc_multiprice_js function should fix this issue.
Comment #28
smartsystems160 commentedHello Docc,
very sorry i didnt get back to you, i was away to a remote city where i could not access the internet. I tried the update you provided but it still gave the javascript error (An error occured. /uc_multiprice/js) so i went into the code in uc_multiprice.module on line 25, and changed the access from 'administer nodes' to 'access content' and it worked like magic, error dissappeared. U indicated in #14 above that it was the access permission in the code that caused the problem, thats what gave me the clue. I am not a coder, hope i did this right. Thanks for the module, Docc.
the error i am referring to in this case is:
An error occured.
/uc_multiprice/js
Comment #29
Docc commented@itpromanager
The latest dev should work for you. A fix for the permission problem is commited.
Comment #30
marvzz commentedi confirm the issue is still present on the latest -dev
Comment #31
harvlad commented@marvzz Have you previously tried patching this module? I had done so, then installed a fresh copy but forgot about the patch file in the root dir.