Re-order functions in menu.install

deekayen - August 4, 2009 - 06:54
Project:Drupal
Version:7.x-dev
Component:menu system
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Issue tags:Novice
Description

In the spirit of #263956: Ye Grande Olde Drupal 7 .install File Cleanup, this breaks up the work a bit since the original issue is a huge bite to try to tackle in one patch. This patch moves the functions around in menu.install to put the functions in order of schema, install, uninstall. No code was changed - only the order of the functions.

AttachmentSizeStatusTest resultOperations
menu_install_cleanup.patch3.4 KBIdleFailed: Failed to apply patch.View details | Re-test

#1

boombatower - August 5, 2009 - 04:52
Status:needs review» reviewed & tested by the community

Looks good.

#2

System Message - September 10, 2009 - 10:01
Status:reviewed & tested by the community» needs work

The last submitted patch failed testing.

#3

lambic - September 21, 2009 - 18:08
Status:needs work» needs review

maybe the bot will like this one better

AttachmentSizeStatusTest resultOperations
menu_install_cleanup.patch3.21 KBIdleFailed: Failed to apply patch.View details | Re-test

#4

andypost - September 25, 2009 - 20:01
Status:needs review» reviewed & tested by the community

looks good

#5

System Message - October 9, 2009 - 22:50
Status:reviewed & tested by the community» needs work

The last submitted patch failed testing.

#6

lambic - October 13, 2009 - 12:22

rerolled patch

AttachmentSizeStatusTest resultOperations
menu_install_cleanup.patch3.13 KBIdlePassed: 13835 passes, 0 fails, 0 exceptionsView details | Re-test

#7

lambic - October 13, 2009 - 13:37
Status:needs work» needs review

#8

andypost - October 13, 2009 - 15:59
Status:needs review» reviewed & tested by the community

back to rtbc again

#9

Dries - October 13, 2009 - 18:36
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD.

#10

System Message - October 27, 2009 - 18:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.