Download & Extend
Issues

Re-order functions in menu.install

Posted by deekayen on August 4, 2009 at 6:54am
Project:Drupal core
Version:7.x-dev
Component:menu system
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:Novice

Issue Summary

In the spirit of #263956: Ye Grande Olde Drupal 7 .install File Cleanup, this breaks up the work a bit since the original issue is a huge bite to try to tackle in one patch. This patch moves the functions around in menu.install to put the functions in order of schema, install, uninstall. No code was changed - only the order of the functions.

AttachmentSizeStatusTest resultOperations
menu_install_cleanup.patch3.4 KBIdleFailed: Failed to apply patch.View details
Login or register to post comments

Comments

#1

Posted by boombatower on August 5, 2009 at 4:52am
Status:needs review» reviewed & tested by the community

Looks good.

#2

Posted by System Message on September 10, 2009 at 10:01am
Status:reviewed & tested by the community» needs work

The last submitted patch failed testing.

#3

Posted by lambic on September 21, 2009 at 6:08pm
Status:needs work» needs review

maybe the bot will like this one better

AttachmentSizeStatusTest resultOperations
menu_install_cleanup.patch3.21 KBIdleFailed: Failed to apply patch.View details

#4

Posted by andypost on September 25, 2009 at 8:01pm
Status:needs review» reviewed & tested by the community

looks good

#5

Posted by System Message on October 9, 2009 at 10:50pm
Status:reviewed & tested by the community» needs work

The last submitted patch failed testing.

#6

Posted by lambic on October 13, 2009 at 12:22pm

rerolled patch

AttachmentSizeStatusTest resultOperations
menu_install_cleanup.patch3.13 KBIdlePassed: 13835 passes, 0 fails, 0 exceptionsView details

#7

Posted by lambic on October 13, 2009 at 1:37pm
Status:needs work» needs review

#8

Posted by andypost on October 13, 2009 at 3:59pm
Status:needs review» reviewed & tested by the community

back to rtbc again

#9

Posted by Dries on October 13, 2009 at 6:36pm
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD.

#10

Posted by System Message on October 27, 2009 at 6:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here