By AjK on

My "Mission Statement", as entered via Admin>Settings contains HTML.

When using 4.6.6, the "mission statement" suddenly decides to strip HTML.

Switching back to 4.6.5 and the HTML is displayed again ok.

Any reason why 4.6.6 descides to strip out html ? Can't seem to find an
"issue" relating to the sudden change in behaviour.

--AjK

⋅ Categories: Drupal 4.6.x

Comments

chx’s picture

chx commented

it allows a limited subset of HTML.
--
My developer blog. | The news is Now Public | Ask not what Drupal can do for you -- ask what you can do for Drupal.

--
Drupal development: making the world better, one patch at a time. | A bedroom without a teddy is like a face without a smile.

AjK’s picture

AjK commented

but 4.6.5 must have allowed for a greater subset (if not all). How do I make 4.6.6 behave as 4.6.5 did?

Regards
--AjK

AjK’s picture

AjK commented

but 4.6.5 must have allowed for a greater subset (if not all). How do I make 4.6.6 behave as 4.6.5 did?

Regards
--AjK

siteformer’s picture

siteformer commented

Try to remove the filter_xss function in the updated phptemplate.engine (line 146 in 4.7 beta 6):

Replace
$mission = filter_xss(theme_get_setting('mission'));

with

$mission = theme_get_setting('mission');

René

AjK’s picture

AjK commented

Hi, thanks for that.

We use the xtemplate engine rather than the phpTemplate engine.

I found:

$xtemplate->template->assign("mission", filter_xss($mission));

I tried:

$xtemplate->template->assign("mission", theme_get_setting($mission));

but that didn't work. But this did work:-

$xtemplate->template->assign("mission", $mission);

regards
--AjK

loloyd’s picture

loloyd commented

Thank you very much, karpuz! I can't thank you enough! I've recently upgraded from 4.6.5 to 4.6.6 too and I have HTML with img tag in my Mission section. It ceased working and after applying this simple change, it now works! Now, the upgrade is 99.9% seamless and transparent. Hehehe...

But, because I'm a *safety* git, I commented the original 4.6.6 line instead to:
// $xtemplate->template->assign("mission", filter_xss($mission));
just in case any other suprises happen.

Arkar’s picture

Arkar commented

I use html in one of my mission this is very bad.