Closed (fixed)
Project:
IE 6 Update
Version:
6.x-1.1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Aug 2009 at 15:08 UTC
Updated:
8 Apr 2010 at 12:07 UTC
The way this module adds the js to the page is a bad idea IMO, and likely not to work in many situations. Consider this common occurrence:
<?php
drupal_add_js($file);
$vars['scripts'] = drupal_get_js();
?>
Which would essentially wipe out what the ie6update module has added to the scripts variable.
I would recommend using hook_footer instead. Patch attached.
| Comment | File | Size | Author |
|---|---|---|---|
| ie6update_footer.patch | 1.06 KB | q0rban |
Comments
Comment #1
rjbrown99 commented+1
The initial module would not work for me based on the interaction with my theme and other modules. Your hook_footer patch does indeed fix the problem. I agree with this approach and suggest that the module author consider it.
Thank you.
Comment #2
jrglasgow commentedthis has been committed
Comment #4
benone commentedHas been committed to what version ?
I downloaded last for D6 and it not works.
I need jquery_update and cant disable it.
Comment #5
benone commentedI added the patch it works now. Just need to know what to do to show it only once ? And it shows vertical scrollbar in ie6 , it doesnt looks good.
Anyway , I woul like to show it to my user only once.
Any ideas ?