When the performance option Optimize Javascript is ON, then editablefields shows two bugs:

1. the [edit] link is shown twice on page-load (you can see it duplicate);
2. the select box (for select list fields) is so buggy, you can't select anything - the select list hides and shows as you try to make a selection, as if its teasing you deliberately;

The problem is extra strange, because it only happens when misc/drupal.js is optimized. Taking that one out, it works again. Believe me, I spent an hour looking for it. E.g. if everything is optimized, except drupal.js, it works. Otherwise above to bugs occur. Extremely annoying.

And a third bug is:

3. In firefox, after saving a selection, I see in Firebug this: "no element found, line 1, www.domain.com/editablefields_submit"

Comments

Anonymous’s picture

Anonymous (not verified) commented

Now I know something more

in editablefields.module, on line 144:
// Allow other modules to extend the data returned.
drupal_alter('ajax_data', $object, 'editablefields', $html);

THAT line was the culprit for my problem. I commented it out. And everything working fine now. With that line active, in IE6-IE7 even my complete website layout was "damaged". IN IE6 my header changed color, as if an old broken TV set. Weird. The power of Javascript! ...

So the JS Optimize setting wasnt the problem.

markfoodyburton’s picture

markfoodyburton commented

Sounds like your issue may be with another module - the purpose of that line is to allow other modules to include javascript in the returned ajax data.

Cheers

Mark.

ManyNancy’s picture

ManyNancy commented

This is because ajax load loads all your css and js again. If inheritances are not done in a way that IE likes, stuff can be messed up...

This is similar to this issue: #575902: Click to edit not working in Chrome, but I'm not sure if it's a dupe. Clearly some modules' js when loaded twice, gets funky. Can we, with all our brain power, figure out which module it is. :D

@Mark, this module does not work well yet, can you please take another look at it and try to sort out bugs. Thanks.

markfoodyburton’s picture

markfoodyburton commented
Status: Active » Postponed (maintainer needs more info)

If I had any clue what was broken, I could - perhaps - have a shot at fixing it. In the meantime, if it itches you - scratch it.

geerlingguy’s picture

geerlingguy commented

Same problem as morningtime, same fix works for me... (his fix in #1). I could maybe try disabling a couple here and there to see if they cause the problem...

Here are the javascript files that are included on my pages with editablefields:

<script type="text/javascript" src="/misc/jquery.js?o"></script>
<script type="text/javascript" src="/misc/drupal.js?o"></script>
<script type="text/javascript" defer="defer" src="/sites/all/modules/admin_menu/admin_menu.js?o"></script>
<script type="text/javascript" src="/sites/all/modules/ajax_load/ajax_load.js?o"></script>
<script type="text/javascript" src="/sites/all/modules/dhtml_menu/dhtml_menu.js?o"></script>
<script type="text/javascript" src="/sites/all/modules/ie6nomore/ie6nomore.js?o"></script>
<script type="text/javascript" src="/sites/all/modules/og/og.js?o"></script>
<script type="text/javascript" src="/sites/all/modules/ubercart/uc_roles/uc_roles.js?o"></script>
<script type="text/javascript" src="/sites/all/modules/views_slideshow/js/jquery.cycle.all.min.js?o"></script>
<script type="text/javascript" src="/sites/all/modules/views_slideshow/contrib/views_slideshow_singleframe/views_slideshow.js?o"></script>
<script type="text/javascript" src="/sites/all/modules/views_slideshow/contrib/views_slideshow_thumbnailhover/views_slideshow.js?o"></script>
<script type="text/javascript" src="/misc/jquery.form.js?o"></script>
<script type="text/javascript" src="/sites/all/modules/editablefields/editablefields.js?o"></script>
<script type="text/javascript" src="/sites/default/themes/archstl/js/urchin.js?o"></script>
<script type="text/javascript" src="/sites/default/themes/archstl/js/jquery.hoverIntent.minified.js?o"></script>
<script type="text/javascript" src="/sites/default/themes/archstl/js/jquery.hint.js?o"></script>
<script type="text/javascript" src="/sites/default/themes/archstl/js/onblur.js?o"></script>
<script type="text/javascript" src="/sites/default/themes/archstl/js/easySlider1.7.js?o"></script>
<script type="text/javascript" src="/sites/default/themes/archstl/js/mega_menu.js?o"></script>
<script type="text/javascript">
<!--//--><![CDATA[//><!--
jQuery.extend(Drupal.settings, { "basePath": "/", "admin_menu": { "margin_top": 1 }, "CTools": { "pageId": "page-ea95f56c5d435ca45d741d97068c8a7f" }, "dhtmlMenu": { "slide": "slide", "siblings": "siblings", "children": "children", "clone": "clone", "doubleclick": "doubleclick", "relativity": 0 }, "editablefields": { "url_html": "http://archstl.org/editablefields_html", "url_submit": "http://archstl.org/editablefields_submit", "clicktoedit_message": "\x3cdiv class=\"editablefields_clicktoedit_message\"\x3e[edit]\x3c/div\x3e" } });
//--><!]]>
</script>
geerlingguy’s picture

geerlingguy commented
Status: Postponed (maintainer needs more info) » Active

My own internal tracking of the issue: http://archstldev.com/node/380#comment-408

geerlingguy’s picture

geerlingguy commented
Version: 6.x-1.2 » 6.x-2.x-dev

What if you had a variable for editablefields that would allow us to programatically disable the variable in settings.php - a variable like "editablefields_allow_alter" - if this is set to 0 or off, it would disable that line of code... I think that could be the default behavior, because that one line of code makes the entire compressed .js file for the site reload, causing this ajax error... and if someone were going to do a drupal_alter on the js from editablefields, they would be wise enough to switch the variable.

rjbrown99’s picture

rjbrown99 commented

+1, same problem here.

I am going completely from memory here, but can you guys check if you are using the ajax_load module? I recall a similar problem with that module integrating with a different one. Again not basing this on science but it sounds familiar.

EDIT: I think this is what I was talking about: #685918: Drupal.theme functions implemented by other modules are broken when javascript compression is enabled

EDIT2: Nope, my problem is different. Please ignore as I'm having a different issue.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue summary: View changes
Status: Active » Closed (outdated)

Closing this to triage the queue. Feel free to comment if you'd like this to be re-opened, though currently there is nobody supporting the 6.x branch.