versvs [versvs] [#540660]

To whom it may concern,

As I'm using the CVS-application form to contact you, the purpose of this message is already clear, but I would like to argue on my application.

I'm here just because I wanted to submit my home-designed drupal theme to the site, in order to make it publicly (and easily) available (yes, i can make the project available through my site, but it will be harder to find by others and also bugs will be more difficult to raise -and remove- without the feedback).

I'm still getting with the "coding standards", though i guess my code will need fewer changes to match the standards, i guess it will take me some time to get it. So, even in the case you evaluate my application positively and even if it happens at the speed of light, don't expect the theme to be uploaded for review too soon. Anyway, it's already finished and it's running on my own drupal-based site since May, 2009.

I don't want to waste your time, so i guess that's all for now. If you need something from me, don't hesitate to contact/ask me.

Looking forward to have news from you.

Sincerely,

Comment	File	Size	Author
#1	shadeofbrown.tar_.gz	65.81 KB	versvs

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

versvs CreditAttribution: versvs commented 5 August 2009 at 12:14

Status:

Postponed (maintainer needs more info)

» Needs review

File	Size
shadeofbrown.tar_.gz	65.81 KB

Comment #2

versvs CreditAttribution: versvs commented 5 August 2009 at 12:18

I forgot to add the link to the live-demo (actually it's not a demo, it's my own site running the theme) of the theme. http://www.versvs.net/ Though the running version on my site is not the last and minor changes (and a final rename of the theme, too) may be seen as differences.

Comment #3

ultimateboy CreditAttribution: ultimateboy commented 5 August 2009 at 15:06

Status:

Needs review

» Needs work

I am sure it is just a small issue in the tarball, but there are files such as node.tpl.php~ and page.tpl.php~.. just dont commit these :)

In terms of coding standards, spacing is off in almost all of your tpl files. Make sure the code is understandable and that it is indented (with spaces) correctly. It's a bit of a minor point, but some of these tpl files are quite hard to read.

Another minor point is the lack of a use a sprite. It might be best to make a single sprite with all of your icons. Not required of course, but it does reduce the number of requests.

In page.tpl you have the following code which would probably better be replaced with simply a new region. The idea is a contributed theme never has to be modified or hacked. If minor alterations are needed, one can create a sub theme based upon your contrib theme, but regardless, things like this should be as configurable as possible.

<!--
<div id="userzone">
  Here you put your ads code. This adds a box (heigh:300px) placed on the rightside, just above the sidebars.
</div>
-->

In node.tpl.php you have the following bit of code. I'd recommend either removing this or translating it to English. All of your class names, ids, and code comments are in english, and it seems a bit out of place. You should also add a condition statement to make sure there are terms before outputting this so that it is not left hanging.

<?php print t('<strong>Archivado en</strong>') ?>

Other than that, this is a solid theme. If you could, simply give it a go at improving the spacing and coding standards throughout along with a few of the other minor points above. Also try to figure out what exactly is going on with the ~ files.