Alex Lawrence [lawrence]

@Alex Lawrence: The status is changed to "needs review" when there is new code to be reviewed, and it is changed to "needs work" when you need to change the code as it is. After you change the code, you change the status to "needs review".

1.   $options = explode( "\n", $field->options );
     // Trim then in order to compare
     foreach ( $options as &$option ) {
       $option = trim( $option );
     }
   

   See the Drupal coding standards to understand how a module code should be written.

2. /**
    * Implementation of hook_token_values().
    */
   function uc_preferred_payment_token_values($type, $object = NULL) {
     $values = array();
     switch ($type) {
       case 'order':
         $order = $object;
   
         $values['order-preferred-payment'] = $order->preferred_payment;
         $values['order-preferred-payment-additional-data'] = str_replace( "\n", "<br />", $order->preferred_payment_additional_data );
     }
     return $values;
   }
   

   The code misses another hook implementation; without it, this hook is useless.

3. 	'primary key' => array('order_id'),
       'indexes' => array(
         'order_id' => array('order_id'),
       ),
   

   The index defined is already the primary key.

4. function uc_preferred_payment_enable() {
     if (!db_table_exists("uc_preferred_payment")){
       drupal_install_schema('uc_preferred_payment');
     }
   }
   

   Module tables are created only in hook_install().

5. function uc_preferred_payment_install() {
     if (!db_table_exists("uc_preferred_payment")){
       drupal_install_schema('uc_preferred_payment');
     }
   }
   
   function uc_preferred_payment_uninstall() {
     if (db_table_exists("uc_preferred_payment")){
       drupal_uninstall_schema('uc_preferred_payment');
     }
   }
   

   The code should be simpler.

Functions should be called with no spaces between the function name, the opening parenthesis, and the first parameter; spaces between commas and each parameter, and no space between the last parameter, the closing parenthesis, and the semicolon.

That means you don't make a call like trim( $string ).

The code must be changed to follow the Drupal coding standards.

There are few points that we insist on, when reviewing the code:

1. The code must be secure.
2. The code must follow the Drupal coding standards.
3. The code must follow the Drupal way to do a task.

Read well the coding standards, and correct the code where it doesn't follow the indications given there.

For the second module (uc_customer_discount.module), I notice there are already 3 modules for Ubercart that do the same task. I am not sure if another one is really needed.

Drupal philosophy is "join forces"; when a module doesn't do what you expect it to do, you can propose patches, or ask to become co-maintainer.

The one that caught my attention is UC Discount Framework; you can find some more modules by searching for uc discount.

That fine, Alex. Take in mind that we don't normally take open an application for more than 2 weeks, when we don't get back any feedback; in such cases, we decline the CVS account, but you can always apply again.

There have not been replies from the OP in the past 7 days. I am marking this report as won't fix.