After upgrading to latest PHP, I get several screenfuls of this error when I want to extract any strings:

Function split() is deprecated in /home/boobaa/public_html/d6/sites/all/modules/potx/potx.inc on line 176.

The extraction runs fine and yields the expected results, though.

CommentFileSizeAuthor
#2 541000-potx-split-deprecated-D6-3.patch759 bytesdave reid

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Category: task » bug

Right. We only use split() for stuff which an explode() can do just as well. (As far as I've seen we only have split() called two times in the code).

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Title: PHP 5.3 incompability » PHP 5.3 incompability: split() deprecated
Version: 6.x-3.0 » 6.x-3.x-dev
Status: Active » Needs review
StatusFileSize
new 541000-potx-split-deprecated-D6-3.patch759 bytes

Patch attached for review that replaces split() with explode().

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Committed to both 6.x and 7.x, thank you!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.