My understanding is that when a user is deleted, their uid should be changed to 0 throughout the database - is that correct? Workflow does not seem to respect this, so that it's possible to have invalid uids in the Workflow tables. This causes subsequent problems in other modules.

I think we should be using hook_user() to capture deletes and update deleted users' uid to 0 in all workflow tables.

CommentFileSizeAuthor
#3 workflow-541088-3.patch548 bytesdanepowell

Comments

danepowell’s picture

danepowell commented

I'm happy to patch this myself but I'd appreciate it if someone could let me know if this is indeed the correct solution before I go to the trouble. Thanks.

jvandyk’s picture

jvandyk commented

I believe the original reason for this was European-style privacy laws that require data retention. But one could argue that in that case the user should not be deleted, only blocked.

danepowell’s picture

danepowell commented
Status: Active » Needs review
StatusFileSize
new workflow-541088-3.patch548 bytes

Here is a patch that takes care of this.

danepowell’s picture

danepowell commented
Version: 6.x-1.1 » 6.x-1.3

This patch works great for me, can someone review it? Or it's so simple can you just commit it?

danepowell’s picture

danepowell commented
Status: Needs review » Reviewed & tested by the community

Bueller? Anyone?

danepowell’s picture

danepowell commented

Is there something preventing this from being committed? This is certainly a bug and goes against Drupal standards, and really does cause weird errors with other modules...

danepowell’s picture

danepowell commented

If you're not willing to commit this please at least have to the courtesy to mark it as "won't fix"... it drives me nuts when RTBC issues sit for years without getting committed (and I have quite a few such issues in my queue right now, cumulatively representing a huge amount of wasted effort.)

jvandyk’s picture

jvandyk commented
Status: Reviewed & tested by the community » Fixed

Committed. Will appear in 6.x-1.5. Sorry for the delay.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.