block_page_alter() queries for both hidden and all regions on every page, but only needs to know about hidden regions on the block admin page.

CommentFileSizeAuthor
#9 block.patch1.53 KBcatch
block.patch1.21 KBcatch

Comments

figaro’s picture

figaro commented

Does the following code actually do anything in your if-statement?:
$visible_regions = system_region_list($theme, REGIONS_VISIBLE)

catch’s picture

catch
he/him
Primary language English
commented

Nope, but the alternative would be a nested if I think, not keen on either.

figaro’s picture

figaro commented

That's my point. If you swap it with isset($visible_regions[$region]) it might just be a tad faster for when the other two conditions fail.

catch’s picture

catch
he/him
Primary language English
commented

That's not possible though, since we need to set $visible_regions in order to do an isset() against it.

figaro’s picture

figaro commented

I understand your approach now, thanks

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Fixed

looks good. this got introduced during some toolbar madness.

catch’s picture

catch
he/him
Primary language English
commented
Status: Fixed » Reviewed & tested by the community

I'm going to set this back to RTBC, since I don't think it got committed.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Favorite-of-Dries

I think it is slightly cleaner to split that if-test. Can you do a quick re-roll?

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new block.patch1.53 KB

Here it is with the nested if.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community
dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Performance, -Favorite-of-Dries

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Performance, +Favorite-of-Dries

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.