The #535098: domain redirection and #537004: "SSL site" option features both need similar backend engines. We need that to be abstracted and easily useable from the frontend. Furthermore, we may eventually want to create a frontend module to create arbitrary vhosts eventually. Vhosts would become nodes (or just be in a separate table) and would be associated with sites (or not) and DNS records (or not).

The important first step is to reflect on how this will be stored in the frontend (nodes or tables) and how it will be communicated to the backend (new command?).

Comments

anarcat’s picture

anarcat commented

I feel we need something better than _provision_apache_create_config($url, $options, $template)... That or we need to fix provision_apache_create_vhost_config so that it is more extensible. ... we need to think about this.

anarcat’s picture

anarcat commented
Project: Hostmaster (Aegir) » Provision
Version: 6.x-0.3-rc2 » 6.x-0.3
anarcat’s picture

anarcat commented
Status: Active » Needs work

I have some vhost create/delete drush commands that are around to create arbitrary files. Still needs to be pushed to CVS.

adrian’s picture

adrian commented

not sure what this "means" and wether the config classes in the backend and the service abstraction solve it.

adrian’s picture

adrian commented
Status: Needs work » Needs review

i actually think this can be considered done.

I have abstracted all of the logic into the server and config class trees.

The nginx, apache and apache_ssl implementations are less than 100 lines and a collection of templates.
We have the backend drush aliases which allow us to store and transfer info.

I also dont see the need for a generic vhost tool. It will only cause site breakages and an entire range of compatibility issues between
the multiple web servers we will end up supporting.

making it as needs review until you can get caught up on the new codebase.

adrian’s picture

adrian commented

Going to mark this as fixed, because we can't really abstract it any further.

we already have 4 http service implementations

adrian’s picture

adrian commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.