Needs review
Project:
Content Type Selector
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
6 Aug 2009 at 14:13 UTC
Updated:
17 Nov 2010 at 10:27 UTC
Jump to comment: Most recent file
Comments
Comment #1
markus_petrux commentedThe output for content type selector is rendered in the help section of the page, using hook_help(). So maybe this is related to the theme? Have you tried with Garland?
Can you see any javascript error on the page?
Comment #2
elfur commentedYes, that's the case. Works with Garland. Need to make room for
hook_help()in my theme.This might be a helpful comment in the readme.txt.
Very convenient little module, now that I realise how it works :)
thanks
Elfur
Comment #3
markus_petrux commentedAh, good to know.
The module code is so small that I didn't thought about adding a note about hook_help(). I'll see if I can add something to the project page, just in case. ;-)
Comment #5
kiko commentedHi!
Congrats for the useful module!. I have a problem showing this in Zen_classic theme. I've checked and in the node.tpl.php appears:
print $help;But the switcher does not show.
Comment #6
Vote_Sizing_Steve commentedLost it too when I changed from Garland to Artisteer-generated theme.
Comment #7
jeffschulerMake sure your theme displays the
#tab-wrapperdiv.Content Type Selector won't display itself unless it finds that DOM element.
In the Acquia Prosper theme, (in which the selector wasn't displaying,) I found where
$tabswere being printed:And wrapped it with
<div id="tabs-wrapper>:(Note that I also had to tweak the theme styles, as, even though I could see the selector I couldn't click it -- the tab bar was being displayed atop.)
I'm re-opening this issue as a request that the module docs also make note of this.
Comment #8
markus_petrux commentedOh, I see.
I'm marking this issue as "needs work". Not only related to documentation, but maybe there's a better way to control the visibility of the select box that is more compatible and/or adaptable to other themes. I'll try to think about it as soon as I have a bit of time.
Comment #9
jorditr commentedHi you all,
I confirm that it was not appearing on my theme until I discovered that even zen theme was not showing the type selector widget. Finally I've realized that garland was embedding the $help variable inside that id="tabs-wrapper", which in fact is quite a particular way to mark it. In my theme I just expected to have a
.
Uhmm, well, it's not enough to tell on your module page that
print $help;is required, but also that it has to be inside some div with the "tabs-wrapper" identifier in order to be properly displayed :-)Thanks anyway for that little helper :-)
Comment #10
asb commentedConfirming the issue for the admin administration module which is based on the Rubik theme; that one is based on the Tao base theme. I'm using Rubik/Tao as administration theme.
Greetings, -asb
Comment #11
asb commentedIssue applies also to the TNT theme Magazeen.
Comment #12
rooby commentedHere is a patch that adds a settings screen where the admin can set the css selector to use when adding the content type selector to the page.
This way the admin can specify a place that suits their theme.
The patch should apply to 6.x-1.2 and 6.x-1.x-dev cleanly.
The content_type_selector.admin.inc file might be overkill for such a small module but i figured I'd go with the standard.
Comment #13
rooby commentedMarked #840758: Selector does not appear in the theme of admin module as a duplicate of this issue.
Comment #14
rooby commentedAs an example, I am using the rootcandy theme and for the new css selector option I use:
Which works pretty nicely.
Comment #15
dan3h commentedIn Rubik, I attached it to
#page-title. Works pretty well. Thanks for the patch, @rooby.Comment #16
rooby commentedNot the best title but it gets the point across.