Download & Extend

Don't clear cache so many times

Project:modr8
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs work

Issue Summary

On modr8_form_submit, cache_clear_all is invoked for every approved node.
cache_clear_all is expensive and doesn't need to be called more than once per page view.
This patch creates a flag which, if set, clears the cache once and only once.

This is marked "bug report" because the amount of overhead created by so many cache_clear_all's could cause out of memory errors or http timeouts.

AttachmentSize
modr8_admin.inc_.patch1.09 KB

Comments

#1

Status:needs review» needs work

I change this code to use node_save() - which itself clear the cache every time. So - this is more of a core issue now than a modr8 issue.

nobody click here