I'm about to commit a new version of img_assist to the CVS repository. I've made many changes, some of which are affected by the img_assist related code that is currently in the tinymce.module.

1. I've attached a patch that disables the "add image" link/icon when TinyMCE is enabled (img_assist will work only with the drupalimage plugin when TinyMCE is enabled). The patch also removes unnecessary img_assist code that isn't needed for the new version of img_assist. Please review and commit this patch as soon as possible since this patch is critical in order to use img_assist with TinyMCE. In the meantime, I will include a patched copy of the tinymce.module file with the img_assist distribution. I'll remove this as soon as the official tinymce release is patched. I know this isn't the ideal way to do things, but it makes it easier for those wishing to try the new version of img_assist right away.

2. Please remove the old version of the drupalimage plugin from the repository. I'm including a new drupalimage plugin with img_assist.

Thanks.

CommentFileSizeAuthor
tinymce_2.patch4.7 KBbenshell

Comments

benshell’s picture

benshell commented

Will this be applied soon? I'd really like to remove the patched copy of the tinymce.module file from img_assist.

gordon’s picture

gordon commented

+1 I am using this patch on a couple of sites with the new img_assist module and it is working great. Can we please have this committed as having the copy of tinymce in img_assist is a pain.

I have also taken a look at the code, and it looks OK, but I don't know tinymce that well.

m3avrck’s picture

m3avrck commented
Status: Needs review » Fixed

Committed, thanks.

benshell’s picture

benshell commented
Status: Fixed » Closed (fixed)

Thanks! I removed the patched copy from img_assist.