Relevant bug #260670: Feed URL is discarded, feed items not saved
Patch is attached.
In a nutshell: feedapi should accept those feeds what are non-processable by the current parser for whatever reason (maybe only network outage).

CommentFileSizeAuthor
#2 542670-2_inaccessible_url.patch1.35 KBaron novak
#1 542670-1_inaccessible_url.patch1.44 KBalex_b
test_inaccessible_url_insert.patch1.45 KBaron novak

Comments

alex_b’s picture

alex_b commented
Status: Needs review » Needs work
StatusFileSize
new 542670-1_inaccessible_url.patch1.44 KB

Really minor things: I adjusted the comments a little bit and moved URL into its own variable for legibility.

Could you add better comments that actually explain what the test does? Can be inline. The most confusing part is that at one point you add a base url in front of an absolute URL.

$feedapi_url = "http://". $this->randomName() .".". $this->randomName(2);
// ...
$absolute_url = $GLOBALS['base_url'] . $feedapi_url;
aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Needs work » Needs review
StatusFileSize
new 542670-2_inaccessible_url.patch1.35 KB

The patch was simplified, confusing parts were removed.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.