Closed (fixed)
Project:
FileField Upload Limit
Version:
5.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
7 Aug 2009 at 14:54 UTC
Updated:
4 Sep 2009 at 10:40 UTC
Here's a patch.
Note that this opens up another bug... #542860: bytesize incorrectly converted to MB?
I've based it on your code on the project page, but not bothered with the max upload size yet.
I've written a function filefield_upload_limit_get_field_upload_limit_string() which gets the effective limit a user has for the given field -- either the per-field limit or the role limit.
I would suggest further refactoring so filefield_upload_limit_filefield uses this function (seeing how it has a bug anyway ;)
Apologies for minor patch mess -- my text editor has trimmed whitespace.
| Comment | File | Size | Author |
|---|---|---|---|
| filefield_upload_limit_description.patch | 6.62 KB | joachim |
Comments
Comment #1
greg.harveyThanks, will review later in the week.
Comment #2
joachim commentedCommitted, as discussed on IRC.
Made a few tweaks to the comments, added proper function doxy headers on my stuff.
Comment #3
greg.harveyThank you! =)