Posted by tomws on August 7, 2009 at 3:42pm
Jump to:
| Project: | MP3 Player |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
mp3player javascript loads on every page. Modules like lightbox2 have page exclusion built in to allow for isolating javascipt to loading only on certain pages (or, conversely, loading all all pages except given pages). Adding that feature will help page-load performance on sites using mp3player.
Patch attached. Actually took the code from the lightbox2 module and modified for mp3player. It uses the variables table to store the pages of interest and removes the variables on uninstall. Adds a function, some form fields, and tweaks mp3player_init(). The patch is based on the latest dev version, but my tests were actually against: mp3player.module,v 1.1.2.10 2009/02/21 12:53:31
| Attachment | Size |
|---|---|
| mp3player_add-page-exclusion-capability.patch | 4.63 KB |
Comments
#1
Fantastic, thanks again!
#2
Automatically closed -- issue fixed for 2 weeks with no activity.