patch: add page exclusion capability

tomws - August 7, 2009 - 15:42
Project:MP3 Player
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

mp3player javascript loads on every page. Modules like lightbox2 have page exclusion built in to allow for isolating javascipt to loading only on certain pages (or, conversely, loading all all pages except given pages). Adding that feature will help page-load performance on sites using mp3player.

Patch attached. Actually took the code from the lightbox2 module and modified for mp3player. It uses the variables table to store the pages of interest and removes the variables on uninstall. Adds a function, some form fields, and tweaks mp3player_init(). The patch is based on the latest dev version, but my tests were actually against: mp3player.module,v 1.1.2.10 2009/02/21 12:53:31

AttachmentSize
mp3player_add-page-exclusion-capability.patch4.63 KB

#1

Starnox - October 13, 2009 - 10:41
Status:needs review» fixed

Fantastic, thanks again!

#2

System Message - October 27, 2009 - 10:50
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.