We were working on this module to integrate a flowplayer plugin. However the plugin requires modification of the flashvars parameter. We thought of not hacking the video module and add the flowplayer plugin as a submodule for the video module. However we saw that there is no hook that allows submodules access to the param array to make any modification. What would be a good way to make this change so that we can contribute this change back to the module.

The use case we are trying to handle is for adding support for openx ads for flowplayer. I am sure lot of people would be looking at embedding ads inside videos. So it would be great if we can make this change usable for others as well.

One way of doing this is to change the theme_video_player_flash function to create the flowplayer code as javascript as suggested in the flowplayer documentation. This modification will allow for other modules to add javascript to manipulate the flowplayer object as well as its plugins. We are planning on doing this but wanted to confirm if this is the right way forward.

Comments

glen201’s picture

glen201 commented
Assigned: Unassigned » glen201
Status: Active » Postponed (maintainer needs more info)

Hi, and thanks for your posting. You are proposing to make the flowplayer support a module like the Youtube video module -- I think that's a noble effort. If you want to contribute this, we would be willing to incorporate it into future releases. We could also provide a method for supporting other Flash-based players in this way (JWPlayer, etc.).

Also, to better accomplish which player gets used in what circumstance, we need to add better support for choosing the player based on extension (.flv, etc.) or you could use a ?player=x query string support for overriding the default.

How would you like to proceed?

--glen

iLLin’s picture

iLLin commented
Status: Postponed (maintainer needs more info) » Closed (fixed)