Meta issue: fix the remaining SQLite bugs

Here is the full test log.

Removed the admin menu failures... that are obviously not core.

Here are the remaining failures as of today:

Invalid data 6 passes, 1 fail, and 0 exceptions

This is probably a borked test.

Field CRUD tests 50 passes, 1 fail, and 0 exceptions

This is because SQLite doesn't trim fixed-precision data by default. I'm unsure how to fix that (except by removing the test).

Session https handling 52 passes, 1 fail, and 1 exception

This is due to #715108: Make Merge queries more consistent and robust.

Locking framework tests 16 passes, 1 fail, and 0 exceptions

This is because of a difference on how MySQL and SQLite handles the notion of "affected row" when there is a float column. I'm pondering.

With #716006: Schema tests fail on SQLite, #714964: ActionLoopTestCase is fragile and #715108: Make Merge queries more consistent and robust applied, we are down to 3 failures!

Invalid data 6 passes, 1 fail, and 0 exceptions
Field CRUD tests 50 passes, 1 fail, and 0 exceptions
Locking framework tests 16 passes, 1 fail, and 0 exceptions

This is the meta-issue, it shouldn't be marked critical.

If you want to help, please open *separate* issues and link them back here.

Actions executing in a potentially infinite loop: 15 passes, 6 fails, and 0 exceptions

This is just due to a granularity issue. I have a patch.

Anonymous comments: 126 passes, 19 fails, and 6 exceptions
Comment approval: 124 passes, 27 fails, and 6 exceptions
Core filters: 129 passes, 0 fails, and 2 exceptions
Node creation: 27 passes, 1 fail, and 0 exceptions
Node edit: 87 passes, 2 fails, and 0 exceptions
String filtering tests: 5 passes, 0 fails, and 1 exception
Drupal render: 5 passes, 2 fails, and 0 exceptions

I never saw those. I'm tempted to say that there is something wrong in your environment.

As of today:

Invalid data 6 passes, 1 fail, and 0 exceptions
Regression tests 24 passes, 1 fail, and 1 exception
Temporary query test 2 passes, 1 fail, and 2 exceptions
Schema API 6 passes, 4 fails, and 1 exception
List field 11 passes, 0 fails, and 1 exception
Field SQL storage tests 72 passes, 0 fails, and 1 exception
Field CRUD tests 46 passes, 1 fail, and 1 exception
File field validation tests 91 passes, 0 fails, and 1 exception
Enable/disable modules 53 passes, 2 fails, and 0 exceptions
Module dependencies 60 passes, 2 fails, and 0 exceptions
Node creation 24 passes, 1 fail, and 0 exceptions
Node edit 91 passes, 2 fails, and 0 exceptions
Basic upgrade path 20 passes, 19 fails, and 9 exceptions

Node creation 24 passes, 1 fail, and 0 exceptions

That was because my version of SQLite didn't support SAVEPOINTs. Upgrading to a newer version fixed that.

Invalid data 6 passes, 1 fail, and 0 exceptions

This is because the base implementation of InsertQuery doesn't actually rollback the transaction if one insert fails.

With the following patches applied:

#851166: SQLite schema implementation doesn't support qualified tables
#851168: db_find_tables() expects tables to be prefixed, inconsistent implementation and documentation
#851110: InsertQuery::execute() needs to rollback the transaction if one insert fail
#851140: DatabaseSchema::getPrefixInfo() is *severely* broken
#850852: Fix transaction failure and allow concurrent testing on SQLite

Here are the three remaining failures tonight:

Field CRUD tests 50 passes, 1 fail, and 0 exceptions
Node edit 91 passes, 2 fails, and 0 exceptions
Basic upgrade path 20 passes, 19 fails, and 9 exceptions

With the following patch stack:

#851698: DatabaseSchema_sqlite severely broken
#851168: db_find_tables() expects tables to be prefixed, inconsistent implementation and documentation
#851110: InsertQuery::execute() needs to rollback the transaction if one insert fail
#851140: DatabaseSchema::getPrefixInfo() is *severely* broken
#850852: Fix transaction failure and allow concurrent testing on SQLite
#809600: Stop using bit-wise operators for {file_managed}.status
#851590: SQLite should "stringify" fetches
#851602: FieldCrudTestCase::testUpdateField() does not test changing the schema

We get 100% pass! Yay!