Zenophile seems to neglect to add its sidebars.css file to the .info file, with the effect that customizations to the page and column widths are ignored. To be clear: it creates sidebars.css just fine. It just doesn't implement it. I observed this problem in beta 5 and beta 6 on multiple sites. I find it hard to believe no one else has noticed, but who knows. If I'm right, I think it's a show-stopper, so I've marked it critical. Workaround: If you're having this problem and can't wait for a patch or an upgrade, all you have to do to fix your subtheme is add the following line to your .info file and clear the theme registry.

stylesheets[all][] = sidebars.css

CommentFileSizeAuthor
#5 crlf2.patch1.75 KBGarrett Albright
#4 crlf.patch1.88 KBGarrett Albright

Comments

Garrett Albright’s picture

Garrett Albright commented

Hmm. What are you using as the parent theme? I can't recall ever having a problem like this when using STARTERKIT or Zen Midnight.

Zenophile uses some not-so-clever regular expressions on the contents of the parent theme's .info file to try to find where it should add its sidebars.css file (and theme-fresh.css file, if you're using that option), so if the parent theme's .info file is substantially different from STARTERKIT's, there may be some trouble there…

traviscarden’s picture

traviscarden commented

I use STARTERKIT every time. A little testing reveals that the problem only occurs when I check the Zen theme out of CVS with Windows line endings. I have a suspicion, then, that the problem exists in the regular expression in zenophile.module between lines 563 and 567:

    $from[] = '/^stylesheets\[all\]\[\]\s*=\s*zen\.css$/m';
    $to[] = "stylesheets[all][]  = zen.css\n  ; Customized sidebar/content widths and positions\nstylesheets[all][]    = sidebars.css";
  }
  // Do replacement and write the info file
  $info = preg_replace($from, $to, $info);
Garrett Albright’s picture

Garrett Albright commented

Hmm. Perhaps the preg library can't handle Windows line endings. I'm not really sure what to do about that.

Garrett Albright’s picture

Garrett Albright commented
StatusFileSize
new crlf.patch1.88 KB

I did some research on this, and it turns out there might be a fairly easy fix. Can you apply patches? If so, could you try applying this patch and let me know if it fixes things?

EDIT: Oops. Try the patch in the next comment.

Garrett Albright’s picture

Garrett Albright commented
StatusFileSize
new crlf2.patch1.75 KB

Oops. Forgot about the whole directories/paths thing when creating patches (again). You should have better luck with this one.

traviscarden’s picture

traviscarden commented

Good job, Garret! #5 did the trick! Thank you very much.

Garrett Albright’s picture

Garrett Albright commented
Title: Sidebars.css not added to .info file » Problems when .info file has Windows-style line breaks
Priority: Critical » Normal
Status: Active » Reviewed & tested by the community

Excellent. Thanks for testing that. I'll get it committed soon.

Garrett Albright’s picture

Garrett Albright commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.